PB-1004 : only use right click to trigger "delete point" action#1249
Merged
PB-1004 : only use right click to trigger "delete point" action#1249
Conversation
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 40s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
268b8ab to
cb7089c
Compare
cb7089c to
9a60ccf
Compare
schtibe
reviewed
Mar 3, 2025
Contributor
schtibe
left a comment
There was a problem hiding this comment.
I think the help text needs updating:
Also, right clicking on a point that isn't an edge or on the line deletes the last point. Is that intended?
53b300d to
1a4445d
Compare
1a4445d to
34e089c
Compare
schtibe
approved these changes
Mar 17, 2025
441e141 to
61beb5c
Compare
users on touch devices could trigger a delete by double tapping on the last point they were drawing, which wasn't ideal. As I've run out of ideas on how to fix this on mobile, I've simply removed the possibility to delete a point on mobile as we lack "gestures" to achieve it.
we need to have right click hooked up to the "delete point under cursor" when not editing/extending a feature
61beb5c to
5b5aa07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
users on touch devices could trigger a delete by double tapping on the last point they were drawing, which wasn't ideal.
As I've run out of ideas on how to fix this on mobile, I've simply removed the possibility to delete a point on mobile as we lack "gestures" to achieve it.
Test link