Merged
Conversation
5e000a6 to
db9c797
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-1432-migrate-to-floating-ui
|
| Run status |
|
| Run duration | 04m 54s |
| Commit |
|
| Committer | Stefan Heinemann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
23
|
|
|
0
|
|
|
240
|
| View all changes introduced in this branch ↗︎ | |
5c9d51a to
9d33def
Compare
a44ebbf to
8a18b4f
Compare
ff0b18d to
a121fd0
Compare
This reverts commit 813c51a.
Use input event and don't debounce the change in the slider
The transparency slider doesn't work correctly when there are more than one layer with the same ID. The opacity will be changed on the first layer that is found in the list instead of the one that it's applied on
This reverts commit 97a44a5.
The civil icon descriptions weren't appearing anymore, maybe due to a refactoring mistake
Improve the geoadmin tooltip so that it can be specified to use the padding even if the content slot is used. This removes the need for adding the same padding in several places
This makes us ready for a future switch away from bootstrap
This reverts commit 8dc6bb9.
Due to the nature of GeoadminTooltip an element was wrapped with that new component. This lead to the situation where cypress couldn't select the correct element. Now instead of working around this with a prop to the component lets change the selector in cypress and add the attribute programmatically just before creating the ol/Overlay
This reverts commit 3ba9c96.
[sort-package-json](https://www.npmjs.com/package/sort-package-json)
4a5c8a8 to
27fb98e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since tippy.js has been flagged deprecated, created a new component that uses floating-ui as the basis for tooltips.
I created a new component
GeoadminTooltipthat handles the uses cases we have. It wraps around elements that should have a tooltip. There are several advantages with that:In general I would say this is more lightweight, with the drawback that it's all custom (instead of using a pre-existing library). (Maybe the latter could've been a way to solve this problem, too, but when starting the endeavor I wasn't fully aware of the scope of it)
Some additional notes.
Test link