Don't render invisible layer catalogue items#1250
Merged
Conversation
85f9eb2 to
0fcefed
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Stefan Heinemann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
Don't render the invisible layer catalogue items. Only render them when the nested navigation is un-collapsed. This produces quite a performance gain, as many sub-sequent components don't need rendering. This includes <TextTruncate>, where each of them creates a ResizeObserver on the DOM. Without this change we have ~1100 resize observers, with the change there are only ~250. I will investigate those ~250 maybe in another attempt, some of them might be resolved when switching to the new tooltip.
0fcefed to
31a717a
Compare
pakb
approved these changes
Feb 20, 2025
Contributor
pakb
left a comment
There was a problem hiding this comment.
Good old v-show playing a trick on us, nice finding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't render the invisible layer catalogue items. Only render them when the nested navigation is un-collapsed.
This produces quite a performance gain, as many sub-sequent components don't need rendering. This includes
<TextTruncate>, where each of them creates a ResizeObserver on the DOM. Without this change we have ~1100 resize observers, with the change there are only ~250.I will investigate those ~250 maybe in another attempt, some of them might be resolved when switching to the new tooltip.
This results in quite the performance gain, mostly noticable in development mode.
Test link