PB-1208 : Have layer legend behind the menu on mobile#1243
Merged
sami-nouidri-swisstopo merged 8 commits intodevelopfrom Feb 19, 2025
Merged
PB-1208 : Have layer legend behind the menu on mobile#1243sami-nouidri-swisstopo merged 8 commits intodevelopfrom
sami-nouidri-swisstopo merged 8 commits intodevelopfrom
Conversation
35ddf71 to
b63703a
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 38s |
| Commit |
|
| Committer | Sami Nouidri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
36d7b15 to
0f6176e
Compare
pakb
previously approved these changes
Feb 17, 2025
pakb
reviewed
Feb 17, 2025
Comment on lines
+199
to
+204
| left: 10px; | ||
| right: 10px; | ||
| transform: unset; | ||
| max-height: calc(100vh - $top-margin); | ||
| max-width: 100vw; | ||
| width: 100vw; | ||
| max-width: 75vw; | ||
| width: 75vw; |
Contributor
There was a problem hiding this comment.
as discussed, please make that active only when a specific prop/flag is present
SimpleWindow changes might lead to some unplanned side-effects, switching to an opt-in approach would be a better way
added 5 commits
February 17, 2025 13:54
025c74a to
9e34bec
Compare
pakb
reviewed
Feb 17, 2025
| <SimpleWindow | ||
| :title="title" | ||
| :small="true" | ||
| :class="{ small }" |
Contributor
There was a problem hiding this comment.
the small class should be added by the SimpleWindow component itself, when the flag is set to true.
You can set a flag (when given as props) just by adding its name to the use of the component.
<SimpleWindow
:title="title"
small
...
/>
pakb
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The layer legend info window has been smaller on mobile displays, and when displayed, closes the menu so as to not obscure the map behind.
Here's a preview of the change :
Test link