Skip to content

PB-1209: Fix no feature tooltip when select feature from search.#1247

Merged
ismailsunni merged 2 commits intodevelopfrom
bug-pb-1209-select-feature-no-info-from-search
Feb 20, 2025
Merged

PB-1209: Fix no feature tooltip when select feature from search.#1247
ismailsunni merged 2 commits intodevelopfrom
bug-pb-1209-select-feature-no-info-from-search

Conversation

@ismailsunni
Copy link
Contributor

@ismailsunni ismailsunni commented Feb 18, 2025

@ismailsunni ismailsunni requested review from ltkum and pakb February 18, 2025 03:05
@github-actions github-actions bot added the bug label Feb 18, 2025
@cypress
Copy link

cypress bot commented Feb 18, 2025

web-mapviewer    Run #4600

Run Properties:  status check passed Passed #4600  •  git commit 393707cffe: Merge pull request #1247 from geoadmin/bug-pb-1209-select-feature-no-info-from-s...
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4600
Run duration 01m 38s
Commit git commit 393707cffe: Merge pull request #1247 from geoadmin/bug-pb-1209-select-feature-no-info-from-s...
Committer Ismail Sunni
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add relevant tests in search-results.cy.js so that we make sure this is there to stay?

@ismailsunni ismailsunni force-pushed the bug-pb-1209-select-feature-no-info-from-search branch from 733e200 to fe40500 Compare February 20, 2025 04:26
@ismailsunni ismailsunni requested a review from pakb February 20, 2025 04:27
@ismailsunni ismailsunni merged commit 393707c into develop Feb 20, 2025
6 checks passed
@ismailsunni ismailsunni deleted the bug-pb-1209-select-feature-no-info-from-search branch February 20, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants