Skip to content

PB-577: Sanitize kml content#1225

Merged
ismailsunni merged 12 commits intodevelopfrom
feat-pb-577-sanitize-kml-content
Feb 20, 2025
Merged

PB-577: Sanitize kml content#1225
ismailsunni merged 12 commits intodevelopfrom
feat-pb-577-sanitize-kml-content

Conversation

@sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Jan 29, 2025

Test link

  • The first link (openstreetmap.org) in title, is pointing to http://evil.com/malware.exe -> blocked
  • The JavaScript code in the descprition -> blocked

Before PR:
image

After PR:
image

Test link

@sommerfe sommerfe self-assigned this Jan 29, 2025
@sommerfe sommerfe force-pushed the feat-pb-577-sanitize-kml-content branch from 1994386 to e154eaf Compare January 29, 2025 13:45
@cypress
Copy link

cypress bot commented Jan 29, 2025

web-mapviewer    Run #4603

Run Properties:  status check passed Passed #4603  •  git commit 15e57678d2: Merge pull request #1225 from geoadmin/feat-pb-577-sanitize-kml-content
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4603
Run duration 01m 39s
Commit git commit 15e57678d2: Merge pull request #1225 from geoadmin/feat-pb-577-sanitize-kml-content
Committer Ismail Sunni
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@sommerfe sommerfe force-pushed the feat-pb-577-sanitize-kml-content branch from e154eaf to f93b392 Compare January 29, 2025 14:46
@ismailsunni ismailsunni marked this pull request as ready for review February 4, 2025 07:02
@ismailsunni
Copy link
Contributor

I believe this PR already covers the ticket from the issue. Unless I missed somehting, it's ready to be reviewed.

@ismailsunni ismailsunni requested a review from pakb February 4, 2025 07:03
@ismailsunni ismailsunni force-pushed the feat-pb-577-sanitize-kml-content branch 2 times, most recently from 573af59 to 2908500 Compare February 13, 2025 05:36
@ismailsunni ismailsunni force-pushed the feat-pb-577-sanitize-kml-content branch 2 times, most recently from 33b9575 to df9939b Compare February 13, 2025 09:22
@ismailsunni ismailsunni requested a review from pakb February 13, 2025 09:33
@ismailsunni ismailsunni force-pushed the feat-pb-577-sanitize-kml-content branch from df9939b to 09eb9ab Compare February 16, 2025 22:54
@ismailsunni ismailsunni requested a review from pakb February 17, 2025 08:45
@ismailsunni ismailsunni force-pushed the feat-pb-577-sanitize-kml-content branch from 9c547fb to c2945c1 Compare February 20, 2025 03:41
@ismailsunni ismailsunni requested a review from pakb February 20, 2025 04:29
@ismailsunni ismailsunni force-pushed the feat-pb-577-sanitize-kml-content branch from c2945c1 to 7c84fff Compare February 20, 2025 06:29
@ismailsunni ismailsunni merged commit 15e5767 into develop Feb 20, 2025
6 checks passed
@ismailsunni ismailsunni deleted the feat-pb-577-sanitize-kml-content branch February 20, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants