Skip to content

Include packages.json formatting in Prettier#1266

Merged
pakb merged 3 commits intodevelopfrom
feat-sort-packages
Mar 17, 2025
Merged

Include packages.json formatting in Prettier#1266
pakb merged 3 commits intodevelopfrom
feat-sort-packages

Conversation

@schtibe
Copy link
Contributor

@schtibe schtibe commented Mar 17, 2025

Add a prettier plugin that sorts the package.json files.

Included the entire codebase in the format command. Running the formatting command resulted in the formatting of even more files, some of which I don't know why they weren't formatted before.

Test link

schtibe added 3 commits March 17, 2025 13:50
Previously, the formatting target in package.json only targeted the code
underneath packages/.

If we want to include the package.json in the root level, maybe we
should allow formatting the entire codebase. This has an effect of the
ADR as well as the README's, but maybe that's not even a a bad thing
@schtibe schtibe changed the title Feat sort packages Include packages.json formatting in Prettier Mar 17, 2025
@schtibe schtibe requested a review from pakb March 17, 2025 12:56
Development of the drawing module can now start with OpenLayers as its backbone.
In order to make it clear it is a different module as the map module, we will inject the curren/component-provide-inject.html)
# Drawing library
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably line ending changed 🤔

@cypress
Copy link

cypress bot commented Mar 17, 2025

web-mapviewer    Run #4807

Run Properties:  status check passed Passed #4807  •  git commit 7a0f76b1bd: Merge pull request #1266 from geoadmin/feat-sort-packages
Project web-mapviewer
Branch Review develop
Run status status check passed Passed #4807
Run duration 01m 38s
Commit git commit 7a0f76b1bd: Merge pull request #1266 from geoadmin/feat-sort-packages
Committer Pascal Barth
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 48
View all changes introduced in this branch ↗︎

@pakb pakb merged commit 7a0f76b into develop Mar 17, 2025
9 checks passed
@pakb pakb deleted the feat-sort-packages branch March 17, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants