Conversation
Contributor
mslipper
commented
Jun 18, 2022
- feat(cmn): BSV2 collects default metrics (feat(cmn): BSV2 collects default metrics #2754)
- contracts-governance: fix the mint manager (contracts-governance: fix the mint manager #2737)
- Bedrock: share more test utils, cleanup derive package structure, move payload/attributes types to eth package (Bedrock: share more test utils, cleanup derive package structure, move payload/attributes types to eth package #2761)
- feat: nft bridge from l1 to optimism (feat: nft bridge from l1 to optimism #2662)
- contracts bedrock: implement simple proxy + admin (contracts bedrock: implement simple proxy + admin #2728)
- CI: Enable full semgrep scan on develop (CI: Enable full semgrep scan on develop #2760)
- make: Remove dead command (make: Remove dead command #2768)
- feat: introduce hardhat-deploy-config (feat: introduce hardhat-deploy-config #2755)
- ci: better snapshot check (ci: better snapshot check #2769)
- makefile improvements (make: Misc Makefile Improvements #2772)
- feat(ctb): update L2 contract style (feat(ctb): update L2 contract style #2764)
- feat(ctp): deploy to kovan and OP kovan (feat(ctp): deploy to kovan and OP kovan #2758)
- feat(ci): download and cache solidity compilers (feat(ci): download and cache solidity compilers #2767)
- feat(ctp): simplify and standardize ERC721 bridge (feat(ctp): simplify and standardize ERC721 bridge #2773)
- Check if Foundry is installed before building (Check if Foundry is installed before building #2777)
- feat(BaseServiceV2):End immediately when looping (feat(BaseServiceV2):End immediately when looping #2731)
- Goerli devnet external replicas (Goerli devnet external replicas #2775)
- Goerli devnet replicas (Goerli devnet replicas #2774)
- bedrock: fix OZ-H-O2 Token address ordering (bedrock: fix OZ-H-O2 Token address ordering #2778)
- ci: Remove buggy assignments rule (ci: Remove buggy assignments rule #2782)
- Additional mainnet replicas (Additional mainnet replicas #2715)
- ci: Fix broken js-builder build (ci: Fix broken js-builder build #2784)
- l2geth: verifier sync in parallel with dtl (l2geth: verifier sync in parallel with dtl #2656)
- feat(ctp): add deploy configuration for NFT bridge (feat(ctp): add deploy configuration for NFT bridge #2780)
- Deployment for bedrock contracts on goerli (Deployment for bedrock contracts on goerli #2783)
- fix: revert es target back to 2017 (fix: revert es target back to 2017 #2786)
- deps: update hh forge plugin (deps: update hh forge plugin #2788)
- Version Packages (Version Packages #2790)
- bedrock: Proxy Admin improvements (bedrock: Proxy Admin improvements #2787)
- feat(ctp): deploy NFT bridge to Kovan (feat(ctp): deploy NFT bridge to Kovan #2791)
- contracts: Fix L-01 use _from instead of msg.sender
- contracts: Fix OZ-L-04 warn about nonstandard tokens
- contracts: Fix OZ-L-05 Warn about trapped funds
- contracts: Fix OZ-N-01 ETH can be stolen
- contracts: Fix OZ-N-03 Complex ERC165 implementation
- contracts: Fix OZ-N-04 Hardcoded values
- contracts: Fix OZ-N-05 Misleading or unclear comments
- chore: Add changeset and regenerate bindings
- bedrock: Address review feedback
- op-bindings: Provide common.Address types of predeploys (op-bindings: Provide common.Address types of predeploys #2797)
- More predeploy fixes (op-bindings: Use common.Address predeploy types #2802)
- proxyd: Use canned response for eth_accounts (proxyd: Use canned response for eth_accounts #2801)
- op-e2e: test l2 fee redirect; l1 availability fee (op-e2e: test l2 fee redirect; l1 availability fee #2770)
- bedrock: use block number for key in output oracle (bedrock: use block number for key in output oracle #2707)
- contracts: Fix OZ-M-01 refund arguments
- contracts: Fix OZ-M-02 by removing donateEth()
- contracts: Fix OZ-M-04 Disallow reentrant withdrawals
- contracts: Fix OZ-M-05 rename _data to _extraData
- contracts: Fix OZ-M-06 - Unpause functionality
- chore: Add changeset and regenerate bindings
- chore: downgrade to patch
- drippie-mon: Fix build (drippie-mon: Fix build #2812)
- fix(cmm): BSV2 update metrics to more permissive type (fix(cmm): BSV2 update metrics to more permissive type #2805)
- fix(cmn): correctly ignore invalid routes (fix(cmn): correctly ignore invalid routes #2814)
Co-authored-by: Matthew Slipper <me@matthewslipper.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* bedrock: Use startPrank to clean up tests * bedrock: Simplify static calling code in proxy admin * bedrock: rename OpenZeppelin proxy to ERC1967
Adds deployment artifacts for our Kovan deployment of the NFT bridge and all related proxy contracts. Also includes an update to contracts-bedrock to properly export contract sources. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
fixup! contracts: Fix OZ-N-03 Complex ERC165 implementation contracts: Fix OZ-N-03 Complex ERC165 implementation fixup! contracts: Fix OZ-N-03 Complex ERC165 implementation
Also fixes OZ-N-06 which was a single typo.
* op-bindings: Provide common.Address types of predeploys We provide both a string literal which contains the address as const a hex string and as the type common.Address. We typically use addresses in the common.Address type so this avoids users having to do the conversion manually. * Use new predeploy address types Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
We never want to expose Geth's accounts to the public internet, so proxyd will now return `[]` for `eth_accounts` RPC calls without hitting the backend. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This PR depends on #26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After #26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.
* bedrock: use block number for key in output oracle * contracts: Apply seaport style to natspec comments Inspo: https://github.com/ProjectOpenSea/seaport/blob/main/contracts/Seaport.sol * bedrock: Improve oracle error messages * bedrock: update node and proposer with new oracle interface * bedrock: add tests for oracle reorg protection. * Fix op-proposer & withdrawals logic * Golang PR Fixes * specs: use block number for key in output oracle * bedrock: Fix CamelCase on oracle events * bedrock: Update arg name in usage of getL2Output * bedrock: Oracle add computeL2Timestamp and check on append Co-authored-by: Joshua Gutow <jgutow@optimism.io>
This commit also expands on the natspec comments to clarify how the additional data may be used. fixup! contracts: Fix OZ-M-05 rename _data to _extraData
There was no `drippie-mon` target in `Dockerfile.packages`, and the canary build was using the `relayer` target.
* update metrics to more permissive type * changeset Co-authored-by: Will Cory <willcory@Wills-MacBook-Pro.local> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Fixes BSV2 to correctly ignore invalid routes in metrics by normalizing them to /invalid_path_not_a_real_route.
🦋 Changeset detectedLatest commit: 10e4152 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Hey @mslipper! This PR has merge conflicts. Please fix them before continuing review. |
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Uniswap labs runs bootnodes dedicated to the CL as well as to the EL. I have added rather than replaced because both EL and CL bootnodes are present in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.