bedrock: use block number for key in output oracle#2707
Merged
mergify[bot] merged 11 commits intodevelopfrom Jun 17, 2022
Merged
bedrock: use block number for key in output oracle#2707mergify[bot] merged 11 commits intodevelopfrom
mergify[bot] merged 11 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: c037cfb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
be9ab8d to
565c150
Compare
maurelian
commented
Jun 7, 2022
565c150 to
f29beb3
Compare
maurelian
commented
Jun 7, 2022
f29beb3 to
7a23fbc
Compare
Contributor
|
@maurelian contract tests are failing as well |
49f4d1d to
24824d5
Compare
maurelian
commented
Jun 9, 2022
a499c59 to
fddf616
Compare
68f0f94 to
ae7ff4a
Compare
1f3d02a to
d702324
Compare
maurelian
commented
Jun 9, 2022
Contributor
|
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
60ad340 to
e84716b
Compare
e84716b to
0c0363d
Compare
0c0363d to
c037cfb
Compare
smartcontracts
approved these changes
Jun 17, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Switching back to the official `optimism-package` to support latest changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces L2 timestamps with block numbers as the key in
mapping(uint => OutputProposal).Additional context
This also enables us to remove the
computeL2BlockNumber()function.I will handle RBAC implementation in a subsequent PR.
TODO:
Metadata