Skip to content

Deployment for bedrock contracts on goerli#2783

Merged
mergify[bot] merged 6 commits intodevelopfrom
contracts-bedrock-goerli-deployment
Jun 15, 2022
Merged

Deployment for bedrock contracts on goerli#2783
mergify[bot] merged 6 commits intodevelopfrom
contracts-bedrock-goerli-deployment

Conversation

@optimisticben
Copy link
Copy Markdown
Contributor

Description
Deployment for bedrock contracts on goerli

Created a deployment config for goerli and a hardhat network config that required ENV vars.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 15, 2022

🦋 Changeset detected

Latest commit: 71b8725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/contracts-bedrock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should eventually standardize the hh config across packages so the same commands just work between them

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Jun 15, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 0a5ca8b into develop Jun 15, 2022
@mergify mergify bot deleted the contracts-bedrock-goerli-deployment branch June 15, 2022 16:32
@mergify mergify bot removed the on-merge-train label Jun 15, 2022
@mslipper mslipper mentioned this pull request Jun 18, 2022
theochap added a commit that referenced this pull request Dec 10, 2025
## Description

We have a race condition in our sequencer block building process:
- When it starts building a block, the sequencer (through the CL node)
sends a `forkchoice_updated` RPC query to the EL
- The L2 EL starts building an empty payload as soon as we query the RPC
endpoint `forkchoice_updated`
- Right after, the CL node sends `get_payload` which seals a payload for
publication

We may have a race condition where the txs from the EL mempool never get
included inside the EL payloads because the blocks get sealed too fast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants