Skip to content

feat(ci): download and cache solidity compilers#2767

Merged
mergify[bot] merged 2 commits intodevelopfrom
sc/cache-sol-compilers
Jun 14, 2022
Merged

feat(ci): download and cache solidity compilers#2767
mergify[bot] merged 2 commits intodevelopfrom
sc/cache-sol-compilers

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Downloads and caches the Solidity compilers to avoid CI errors where
circle seems to be getting rate limited. Checks compilers against known
hashes to guarantee that we're not getting any sort of error during this
caching step.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 13, 2022

🦋 Changeset detected

Latest commit: bcc807b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@eth-optimism/js-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Downloads and caches the Solidity compilers to avoid CI errors where
circle seems to be getting rate limited. Checks compilers against known
hashes to guarantee that we're not getting any sort of error during this
caching step.
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 14, 2022

This PR has been added to the merge queue, and will be merged soon.

Copy link
Copy Markdown
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the 0.5 solc for weth but lgtm, would recommend breaking into a bash function

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 14, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 8a8efd5 into develop Jun 14, 2022
@mergify mergify bot deleted the sc/cache-sol-compilers branch June 14, 2022 18:19
@mergify mergify bot removed the on-merge-train label Jun 14, 2022
@mslipper mslipper mentioned this pull request Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ops Area: ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants