feat(ctp): simplify and standardize ERC721 bridge#2773
Merged
mergify[bot] merged 12 commits intodevelopfrom Jun 14, 2022
Merged
feat(ctp): simplify and standardize ERC721 bridge#2773mergify[bot] merged 12 commits intodevelopfrom
mergify[bot] merged 12 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: d368015 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
reviewed
Jun 14, 2022
packages/contracts-periphery/contracts/L1/messaging/L1ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
ba7d00c to
43c6519
Compare
tynes
approved these changes
Jun 14, 2022
maurelian
reviewed
Jun 14, 2022
Contributor
maurelian
left a comment
There was a problem hiding this comment.
only one comment so far, still looking.
packages/contracts-periphery/contracts/L1/messaging/L1ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
maurelian
reviewed
Jun 14, 2022
packages/contracts-periphery/contracts/L1/messaging/L1ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
maurelian
reviewed
Jun 14, 2022
packages/contracts-periphery/contracts/L2/messaging/L2ERC721Bridge.sol
Outdated
Show resolved
Hide resolved
Contributor
|
Left some suggestions, nothing blocking. |
maurelian
approved these changes
Jun 14, 2022
Significantly simplifies the ERC721 bridge contracts and standardizes them according to our new seaport-style standard. Removes some unnecessary code and updates the interface for the bridge to match the expected interface for the ERC20 bridge after Bedrock.
7af6fa9 to
e9f6498
Compare
648aec7 to
e9f6498
Compare
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Significantly simplifies the ERC721 bridge contracts and standardizes
them according to our new seaport-style standard. Removes some
unnecessary code and updates the interface for the bridge to match the
expected interface for the ERC20 bridge after Bedrock.