core: handle base fee, l1 availability fee, tx fee by tuxcanfly · Pull Request #26 · ethereum-optimism/reference-optimistic-geth

tuxcanfly · 2022-06-03T17:38:58Z

Description:

This PR implements handling of transaction fees for paying the cost of posting the RLP encoded transaction as part of calldata on L1 and the regular transaction fees on L2. The L1 cost is computed using variables from the GasPriceOracle and L1Block contracts on L2. Both the fees from L1 and L2 are transferred to a configurable fee recipient account.

Note: The PR aims to keep the client compatible for L1 and minimizes the diff required so as to be easily reviewable / auditable.

core/types/transaction.go

les/state_accessor.go

core/l1_gas.go

core/state_transition.go

core/types/transaction.go

core/state_transition.go

core/types/deposit_tx.go

core/l1_gas.go

core/types/transaction.go

core/l1_gas.go

trianglesphere · 2022-06-08T18:34:29Z

Ok, I took a look at the math. My suggestion is as follows:

l1GasUsed := ...
ctx.divisor = new(big.Int).Exp(big10, decimals, nil)
l1Cost := new(big.Int).Mul(l1GasUsed, ctx.BaseFee)
l1Cost = l1Cost.Mul(l1Cost, ctx.Scalar)
l1Cost = l1Cost.Div(l1Cost, ctx.Divisor)

Basically the scalar & decimals in the contract must be set relative to each other & we should only use integer math, not floating point math.

To get a scalar that is like 1.3, the scalar should be 1.3 * 10^decimals & the decimals should be appropriately set.

core/state_transition.go

tuxcanfly · 2022-06-09T14:51:03Z

Ok, I took a look at the math. My suggestion is as follows:
l1GasUsed := ...
ctx.divisor = new(big.Int).Exp(big10, decimals, nil)
l1Cost := new(big.Int).Mul(l1GasUsed, ctx.BaseFee)
l1Cost = l1Cost.Mul(l1Cost, ctx.Scalar)
l1Cost = l1Cost.Div(l1Cost, ctx.Divisor)
Basically the scalar & decimals in the contract must be set relative to each other & we should only use integer math, not floating point math.

To get a scalar that is like 1.3, the scalar should be 1.3 * 10^decimals & the decimals should be appropriately set.

Thanks this works, updated.

params/config.go

core/l1_fee_context.go

core/state_processor.go

trianglesphere · 2022-06-09T18:16:21Z

This is looking pretty good. I only have these couple comments + a proper PR description is what this needs from my side to get it merged.

trianglesphere · 2022-06-10T19:26:25Z

Ok, rerunning tests. It looks like the new auth tests are flaky. Once tests go green, I'll approve.

trianglesphere

LGTM. Please squash this for the merge. Feel free to wait to merge this until testing is all integrated.

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

params/config.go

core/types/transaction.go

params/config.go

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

core/l1_fee_context.go

params/config.go

core/l1_fee_context.go

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

core/types/transaction.go

params/config.go

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

trianglesphere

just the switch to MarshallBinary

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

base fee and l1 availability fee are redirected to configurable accounts; where as tx fee is redirected as coinbase reward

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

tuxcanfly · 2022-06-16T11:59:02Z

Followed up in #27 , same commit as the squashed one here (accidentally closed this PR).

This PR depends on ethereum-optimism#26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After ethereum-optimism#26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.

This PR depends on #26 on reference-optimistic-geth: ethereum-optimism/reference-optimistic-geth#26 A new test TestFees is added, which runs a simple transaction and tests that the L2 fee is redirected to the configured fee recipient and that the L1 availability fee is calculated based the RLP encoded transaction size and also redirected to the configured fee recipient. TestFees is skipped, but can be enabled the above PR is merged into reference-optimistic-geth. NOTE: After #26 reference-optimistic-geth is merged, L2 genesis configuration needs to be updated for OptimismConfig to enable special fee handling and to find L1Block, GasPriceOracle contract addresses.