op-bindings: Provide common.Address types of predeploys#2797
Merged
mergify[bot] merged 3 commits intodevelopfrom Jun 16, 2022
Merged
op-bindings: Provide common.Address types of predeploys#2797mergify[bot] merged 3 commits intodevelopfrom
mergify[bot] merged 3 commits intodevelopfrom
Conversation
We provide both a string literal which contains the address as const a hex string and as the type common.Address. We typically use addresses in the common.Address type so this avoids users having to do the conversion manually.
|
Contributor
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Jun 16, 2022
Contributor
|
This PR has been added to the merge queue, and will be merged soon. |
Contributor
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
tuxcanfly
pushed a commit
to tuxcanfly/optimism
that referenced
this pull request
Jun 16, 2022
…imism#2797) * op-bindings: Provide common.Address types of predeploys We provide both a string literal which contains the address as const a hex string and as the type common.Address. We typically use addresses in the common.Address type so this avoids users having to do the conversion manually. * Use new predeploy address types Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Merged
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
The function returns a deserialized RollupConfig struct, not a string as the comment incorrectly stated. Updated comment to accurately reflect the actual return type. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: theo <80177219+theochap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We provide both a string literal which contains the address as const
a hex string and as the type common.Address.
We typically use addresses in the common.Address type so this avoids
users having to do the conversion manually.