JwtAuthn: support completing padding on forward jwt payload header#16752
Merged
mattklein123 merged 12 commits intoenvoyproxy:mainfrom Jul 2, 2021
Merged
JwtAuthn: support completing padding on forward jwt payload header#16752mattklein123 merged 12 commits intoenvoyproxy:mainfrom
mattklein123 merged 12 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Xuyang Tao <taoxuy@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
Author
Signed-off-by: Xuyang Tao <taoxuy@google.com>
qiwzhang
reviewed
Jun 2, 2021
qiwzhang
reviewed
Jun 2, 2021
Signed-off-by: Xuyang Tao <taoxuy@google.com>
# Conflicts: Merge main Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
qiwzhang
previously approved these changes
Jun 7, 2021
adisuissa
reviewed
Jun 8, 2021
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Left a few API comments.
Signed-off-by: Xuyang Tao <taoxuy@google.com>
adisuissa
reviewed
Jun 9, 2021
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
A couple of API suggestions.
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Signed-off-by: Xuyang Tao <taoxuy@google.com>
Contributor
|
/lgtm api |
Contributor
Author
qiwzhang
previously approved these changes
Jun 10, 2021
lizan
suggested changes
Jun 22, 2021
Signed-off-by: Xuyang Tao <taoxuy@google.com>
lizan
approved these changes
Jun 30, 2021
Contributor
Author
|
Hi @lizan, PTAL. I think the test is flaky. |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 7, 2021
* main: listener: match rebalancer to listener IP family type (envoyproxy#16914) jwt_authn: implementation of www-authenticate header (envoyproxy#16216) listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227) Small typo fix (envoyproxy#17247) Doc: Clarify request/response attributes are http-only (envoyproxy#17204) bazel/README.md: add aspell comment (envoyproxy#17072) docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225) remove the wrong comment on test (envoyproxy#17233) upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179) JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752) remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968) metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127) deps: update cel-cpp to 0.6.1 (envoyproxy#16293) Add ability to filter ConfigDump. (envoyproxy#16774) examples: fix Wasm example. (envoyproxy#17218) upstream: update host's socket factory when metadata is updated. (envoyproxy#16708) Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
…nvoyproxy#16752) Signed-off-by: Xuyang Tao <taoxuy@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…nvoyproxy#16752) Signed-off-by: Xuyang Tao <taoxuy@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuyang Tao taoxuy@google.com
Commit Message: revert back #16576 with adding option in filter API to enable the feature. Fix #16528
Risk Level: Low
Testing: Yes
Docs Changes: Yes
Release Notes: Yes