Revert "JwtAuthn: complete padding on forward jwt payload header"#16576
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom May 25, 2021
Merged
Revert "JwtAuthn: complete padding on forward jwt payload header"#16576lizan merged 1 commit intoenvoyproxy:mainfrom
lizan merged 1 commit intoenvoyproxy:mainfrom
Conversation
Contributor
Author
qiwzhang
previously approved these changes
May 19, 2021
Member
|
Do we want backport this to v1.18.x as well? |
Contributor
Author
|
Yes |
lizan
previously approved these changes
May 20, 2021
Member
Member
|
@TAOXUY can you fix DCO? |
e10be03 to
6af3866
Compare
…oyproxy#14779)" This reverts commit 8b0aacc. Signed-off-by: Xuyang Tao <taoxuy@google.com>
6af3866 to
b1435e7
Compare
Contributor
Author
Done. |
Contributor
|
@lizan: ack. |
lizan
approved these changes
May 25, 2021
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…oyproxy#14779)" (envoyproxy#16576) This reverts commit 8b0aacc. Signed-off-by: Xuyang Tao <taoxuy@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #14779
No all language accept padding by default. The Golang needs to choose either padding or no padding and some our users choose the latter one. Revert as it will break our users. For details, see #16528.