deps: update cel-cpp to 0.6.1 by kyessenov · Pull Request #16293 · envoyproxy/envoy

kyessenov · 2021-05-03T20:17:01Z

Signed-off-by: Kuat Yessenov kuat@google.com

Commit Message: update CEL evaluator to latest release
Risk Level: low
Testing: unit / regression
Docs Changes: none
Release Notes: none

Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only · 2021-05-03T20:17:06Z

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16293 was opened by kyessenov.

see: more, trace.

Signed-off-by: Kuat Yessenov <kuat@google.com>

bazel/repository_locations.bzl

moderation

Would be could to switch to releases for cel-cpp and abseil if possible

moderation

As per comments it would be preferable to switch to releases for both cel-cpp and abseil

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2021-05-05T23:07:28Z

/retest

repokitteh-read-only · 2021-05-05T23:07:32Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

htuch

/lgtm deps

kyessenov · 2021-05-06T18:09:25Z

/retest

repokitteh-read-only · 2021-05-06T18:09:28Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

Signed-off-by: Kuat Yessenov <kuat@google.com>

wrowe · 2021-05-20T15:54:23Z

/retest

repokitteh-read-only · 2021-05-20T15:54:27Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @wrowe.

see: more, trace.

kyessenov · 2021-05-21T05:43:20Z

Windows compiler does not like initializing int64_t constexpr with long values, sending a patch upstream.

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov · 2021-06-26T00:05:41Z

This might require some serious patching of cel-cpp since it assumes aliased string_views when using protobuf. Sigh.

htuch · 2021-06-27T22:27:06Z

@kyessenov is there any way to avoid Envoy-side patches? We're really trying to avoid these going forward.

kyessenov · 2021-06-28T15:44:16Z

@htuch Yes, it can be fixed upstream. It's difficult to enforce in g3, so it just needs regular maintenance to ensure abseil-protobuf use is valid with non-aliased absl and std string_views.

Signed-off-by: Kuat Yessenov <kuat@google.com>

wrowe · 2021-06-28T17:17:00Z

Thank you for identifying the ambiguous long vs int64 issue. Awaiting cleaning up format check

kyessenov · 2021-06-28T19:38:16Z

/retest

repokitteh-read-only · 2021-06-28T19:38:20Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

kyessenov · 2021-06-28T23:58:26Z

The coverage dropped by 0.1% because of dependency upgrade? That is unexpected.

kyessenov · 2021-06-29T20:17:19Z

/retest

repokitteh-read-only · 2021-06-29T20:17:23Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

kyessenov · 2021-06-30T01:09:07Z

/retest

repokitteh-read-only · 2021-06-30T01:09:11Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

wrowe

LGTM /deps ... Unconcerned about third party code coverage

moderation · 2021-06-30T18:05:31Z

/lgtm deps

kyessenov · 2021-07-01T17:04:36Z

/retest

repokitteh-read-only · 2021-07-01T17:04:40Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16293 (comment) was created by @kyessenov.

see: more, trace.

kyessenov · 2021-07-01T17:36:44Z

Yay, took 2 months on-off but finally ready!

* main: listener: match rebalancer to listener IP family type (envoyproxy#16914) jwt_authn: implementation of www-authenticate header (envoyproxy#16216) listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227) Small typo fix (envoyproxy#17247) Doc: Clarify request/response attributes are http-only (envoyproxy#17204) bazel/README.md: add aspell comment (envoyproxy#17072) docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225) remove the wrong comment on test (envoyproxy#17233) upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179) JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752) remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968) metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127) deps: update cel-cpp to 0.6.1 (envoyproxy#16293) Add ability to filter ConfigDump. (envoyproxy#16774) examples: fix Wasm example. (envoyproxy#17218) upstream: update host's socket factory when metadata is updated. (envoyproxy#16708) Signed-off-by: Garrett Bourg <bourg@squareup.com>

Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>

Signed-off-by: Kuat Yessenov <kuat@google.com>

deps: update cel-cpp to 0.5.0

c42112b

Signed-off-by: Kuat Yessenov <kuat@google.com>

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 3, 2021

update abseil as well

1572f09

Signed-off-by: Kuat Yessenov <kuat@google.com>

moderation reviewed May 4, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

moderation reviewed May 4, 2021

View reviewed changes

bazel/repository_locations.bzl Outdated Show resolved Hide resolved

moderation suggested changes May 4, 2021

View reviewed changes

ggreenway assigned moderation May 4, 2021

moderation suggested changes May 4, 2021

View reviewed changes

kyessenov added 3 commits May 4, 2021 13:14

pin to version

67342a1

Signed-off-by: Kuat Yessenov <kuat@google.com>

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

001692b

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

7e0eb5f

htuch previously approved these changes May 6, 2021

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label May 6, 2021

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

a6a8c07

fix url

5da249c

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov dismissed htuch’s stale review via 5da249c May 6, 2021 18:10

repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 6, 2021

kyessenov added 2 commits May 6, 2021 14:06

weird archive

96de9ae

Signed-off-by: Kuat Yessenov <kuat@google.com>

juggle url

91e493d

Signed-off-by: Kuat Yessenov <kuat@google.com>

moderation mentioned this pull request May 26, 2021

Update ABSL to latest LTS version 20210324.2 #16681

Closed

alyssawilk assigned htuch Jun 2, 2021

alyssawilk added the waiting label Jun 2, 2021

kyessenov changed the title ~~deps: update cel-cpp to 0.5.0~~ deps: update cel-cpp to 0.6.0 Jun 25, 2021

typo

7b11f97

Signed-off-by: Kuat Yessenov <kuat@google.com>

kyessenov changed the title ~~deps: update cel-cpp to 0.6.0~~ deps: update cel-cpp to 0.6.1 Jun 28, 2021

kyessenov added 2 commits June 28, 2021 09:25

bump

874027d

Signed-off-by: Kuat Yessenov <kuat@google.com>

fix date

a6a111c

Signed-off-by: Kuat Yessenov <kuat@google.com>

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

88e85c6

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

a7bbdf2

wrowe approved these changes Jun 30, 2021

View reviewed changes

repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jun 30, 2021

htuch removed their assignment Jul 1, 2021

Merge remote-tracking branch 'upstream/main' into update_cel_cpp2

70b121c

mattklein123 merged commit 4071923 into envoyproxy:main Jul 2, 2021

chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021

deps: update cel-cpp to 0.6.1 (envoyproxy#16293)

a82aa77

Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>

leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021

deps: update cel-cpp to 0.6.1 (envoyproxy#16293)

5de388e

Signed-off-by: Kuat Yessenov <kuat@google.com>

Conversation

kyessenov commented May 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented May 3, 2021

Uh oh!

Uh oh!

Uh oh!

moderation left a comment

Choose a reason for hiding this comment

Uh oh!

moderation left a comment

Choose a reason for hiding this comment

Uh oh!

kyessenov commented May 5, 2021

Uh oh!

repokitteh-read-only bot commented May 5, 2021

Uh oh!

htuch left a comment

Choose a reason for hiding this comment

Uh oh!

kyessenov commented May 6, 2021

Uh oh!

repokitteh-read-only bot commented May 6, 2021

Uh oh!

wrowe commented May 20, 2021

Uh oh!

repokitteh-read-only bot commented May 20, 2021

Uh oh!

kyessenov commented May 21, 2021

Uh oh!

kyessenov commented Jun 26, 2021

Uh oh!

htuch commented Jun 27, 2021

Uh oh!

kyessenov commented Jun 28, 2021

Uh oh!

wrowe commented Jun 28, 2021

Uh oh!

kyessenov commented Jun 28, 2021

Uh oh!

repokitteh-read-only bot commented Jun 28, 2021

Uh oh!

kyessenov commented Jun 28, 2021

Uh oh!

kyessenov commented Jun 29, 2021

Uh oh!

repokitteh-read-only bot commented Jun 29, 2021

Uh oh!

kyessenov commented Jun 30, 2021

Uh oh!

repokitteh-read-only bot commented Jun 30, 2021

Uh oh!

wrowe left a comment

Choose a reason for hiding this comment

Uh oh!

moderation commented Jun 30, 2021

Uh oh!

kyessenov commented Jul 1, 2021

Uh oh!

repokitteh-read-only bot commented Jul 1, 2021

Uh oh!

kyessenov commented Jul 1, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kyessenov commented May 3, 2021 •

edited

Loading