listener: reset the file event in framework instead of listener filter doing itself#17227
Conversation
…r doing itself Signed-off-by: He Jie Xu <hejie.xu@intel.com>
|
Do we need release note for this PR? if yes, I guess it should be in the section 'Bug fixes'? |
|
/retest |
|
Retrying Azure Pipelines: |
|
The PR failed on direct source address filter matching test https://dev.azure.com/cncf/envoy/_build/results?buildId=81052&view=logs&j=bbe4b42d-86e6-5e9c-8a0b-fea01d818a24&t=e00c5a13-c6dc-5e9a-6104-69976170e881&l=18024 This probably related to #17118 But I can't reproduce the failure locally. So let me add some log to debug it. |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
|
/retest |
|
Retrying Azure Pipelines: |
Emm....after I add log, the failure disappears... |
This reverts commit bdf45ee. Signed-off-by: He Jie Xu <hejie.xu@intel.com>
mattklein123
left a comment
There was a problem hiding this comment.
Thanks for the follow up. IMO this is a more resilient fix until we do something better. @ggreenway @antoniovicente any objections to this per previous discussions?
|
No objection from me; I agree that this is an improvement from having every listener filter do it. |
antoniovicente
left a comment
There was a problem hiding this comment.
Thanks for the followup cleanup.
* main: listener: match rebalancer to listener IP family type (envoyproxy#16914) jwt_authn: implementation of www-authenticate header (envoyproxy#16216) listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227) Small typo fix (envoyproxy#17247) Doc: Clarify request/response attributes are http-only (envoyproxy#17204) bazel/README.md: add aspell comment (envoyproxy#17072) docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225) remove the wrong comment on test (envoyproxy#17233) upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179) JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752) remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968) metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127) deps: update cel-cpp to 0.6.1 (envoyproxy#16293) Add ability to filter ConfigDump. (envoyproxy#16774) examples: fix Wasm example. (envoyproxy#17218) upstream: update host's socket factory when metadata is updated. (envoyproxy#16708) Signed-off-by: Garrett Bourg <bourg@squareup.com>
…r doing itself (envoyproxy#17227) Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Commit Message: listener: reset the file event in framework instead of listener filter doing itself
Additional Description:
The previous fix of the issue #16951 (#16952) was done by
reset the file event inside the listener filter destruction. But that isn't good enough since it given the burden
to the listener filter developer, and people still may forget to reset the file event. So this PR is going to
reset the file event inside ActiveTcpSocket.
Risk Level: low
Testing: unitest and integration test
Docs Changes: n/a
Release Notes: n/a
Improve the Fixes #16951
Signed-off-by: He Jie Xu hejie.xu@intel.com