metrics service: fix wrong argument arrange on MetricsServiceSink#17127
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Jul 2, 2021
Merged
metrics service: fix wrong argument arrange on MetricsServiceSink#17127mattklein123 merged 3 commits intoenvoyproxy:mainfrom
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Shikugawa <rei@tetrate.io>
jmarantz
previously approved these changes
Jun 24, 2021
jmarantz
reviewed
Jun 24, 2021
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
Seems obviously right to me. It's a little surprising to me that there wasn't a test fix also. Can we have a unit test that calls createStatsSink that fails in the current state but passes with this change?
Contributor
|
/wait |
jmarantz
reviewed
Jun 25, 2021
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
Thanks for adding the test; just a few minor nits.
test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
Outdated
Show resolved
Hide resolved
test/extensions/stats_sinks/metrics_service/grpc_metrics_service_impl_test.cc
Show resolved
Hide resolved
Contributor
|
/wait |
jmarantz
approved these changes
Jun 30, 2021
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
Thanks!
/assign-from @envoyproxy/senior-maintainers
|
@envoyproxy/senior-maintainers assignee is @snowp |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jul 7, 2021
* main: listener: match rebalancer to listener IP family type (envoyproxy#16914) jwt_authn: implementation of www-authenticate header (envoyproxy#16216) listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227) Small typo fix (envoyproxy#17247) Doc: Clarify request/response attributes are http-only (envoyproxy#17204) bazel/README.md: add aspell comment (envoyproxy#17072) docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225) remove the wrong comment on test (envoyproxy#17233) upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179) JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752) remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968) metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127) deps: update cel-cpp to 0.6.1 (envoyproxy#16293) Add ability to filter ConfigDump. (envoyproxy#16774) examples: fix Wasm example. (envoyproxy#17218) upstream: update host's socket factory when metadata is updated. (envoyproxy#16708) Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
…voyproxy#17127) Signed-off-by: Shikugawa <rei@tetrate.io> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…voyproxy#17127) Signed-off-by: Shikugawa <rei@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shikugawa rei@tetrate.io
Commit Message: This is the follow up of this change. #16125
We are passing arguments invertedly to
MetricsServiceSink.https://github.com/envoyproxy/envoy/blob/main/source/extensions/stat_sinks/metrics_service/grpc_metrics_service_impl.h#L122
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]