Skip to content

remove support for v2 UNSUPPORTED_REST_LEGACY#16968

Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
ankatare:remove_v2_support
Jul 2, 2021
Merged

remove support for v2 UNSUPPORTED_REST_LEGACY#16968
mattklein123 merged 3 commits intoenvoyproxy:mainfrom
ankatare:remove_v2_support

Conversation

@ankatare
Copy link
Copy Markdown
Contributor

Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com

Commit Message: remove support for v2 UNSUPPORTED_REST_LEGACY
Additional Description: Another PR of type remove_v2_support. first PR is #16274
Risk Level: LOW
Testing: Yes
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Copy Markdown
Contributor Author

@htuch : please review

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few comments.

@htuch
Copy link
Copy Markdown
Member

htuch commented Jun 16, 2021

/wait

@ankatare
Copy link
Copy Markdown
Contributor Author

@htuch Thanks for review. i will get back ASAP

@htuch
Copy link
Copy Markdown
Member

htuch commented Jun 18, 2021

@ankatare you need to push again

@ankatare
Copy link
Copy Markdown
Contributor Author

@htuch yeah... actually build failing locally .. will push soon

@ankatare
Copy link
Copy Markdown
Contributor Author

@phlax please review

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare ankatare force-pushed the remove_v2_support branch from 2997cd4 to 2c8cd59 Compare June 26, 2021 01:30
@ankatare
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16968 (comment) was created by @ankatare.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one unrelated change I think.
/wait

…nd deliting LegacySubscription test case

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@ankatare
Copy link
Copy Markdown
Contributor Author

ankatare commented Jul 1, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #16968 (comment) was created by @ankatare.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mattklein123 mattklein123 merged commit 5ce4a15 into envoyproxy:main Jul 2, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jul 7, 2021
* main:
  listener: match rebalancer to listener IP family type (envoyproxy#16914)
  jwt_authn: implementation of www-authenticate header (envoyproxy#16216)
  listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227)
  Small typo fix (envoyproxy#17247)
  Doc: Clarify request/response attributes are http-only (envoyproxy#17204)
  bazel/README.md: add aspell comment (envoyproxy#17072)
  docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225)
  remove the wrong comment on test (envoyproxy#17233)
  upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179)
  JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752)
  remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968)
  metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127)
  deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
  Add ability to filter ConfigDump. (envoyproxy#16774)
  examples: fix Wasm example. (envoyproxy#17218)
  upstream: update host's socket factory when metadata is updated. (envoyproxy#16708)

Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: chris.xin <xinchuantao@qq.com>
@ankatare ankatare deleted the remove_v2_support branch August 4, 2021 13:48
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants