Skip to content

examples: fix Wasm example.#17218

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
PiotrSikora:wasm-fix_example
Jul 2, 2021
Merged

examples: fix Wasm example.#17218
phlax merged 1 commit intoenvoyproxy:mainfrom
PiotrSikora:wasm-fix_example

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Previously, the setBuffer API was misused and the size of a new data
was passed instead of the size of data to replace.

Signed-off-by: Piotr Sikora piotrsikora@google.com

Previously, the setBuffer API was misused and the size of a new data
was passed instead of the size of data to replace.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora requested a review from phlax July 1, 2021 23:19
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @PiotrSikora

@phlax phlax merged commit 4d6f446 into envoyproxy:main Jul 2, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jul 7, 2021
* main:
  listener: match rebalancer to listener IP family type (envoyproxy#16914)
  jwt_authn: implementation of www-authenticate header (envoyproxy#16216)
  listener: reset the file event in framework instead of listener filter doing itself (envoyproxy#17227)
  Small typo fix (envoyproxy#17247)
  Doc: Clarify request/response attributes are http-only (envoyproxy#17204)
  bazel/README.md: add aspell comment (envoyproxy#17072)
  docs: Fix broken URL links in HTTP upgrades doc (envoyproxy#17225)
  remove the wrong comment on test (envoyproxy#17233)
  upstream: allow clusters to skip waiting on warmup for initialization (envoyproxy#17179)
  JwtAuthn: support completing padding on forward jwt payload header (envoyproxy#16752)
  remove support for v2 UNSUPPORTED_REST_LEGACY (envoyproxy#16968)
  metrics service: fix wrong argument arrange on MetricsServiceSink (envoyproxy#17127)
  deps: update cel-cpp to 0.6.1 (envoyproxy#16293)
  Add ability to filter ConfigDump. (envoyproxy#16774)
  examples: fix Wasm example. (envoyproxy#17218)
  upstream: update host's socket factory when metadata is updated. (envoyproxy#16708)

Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
Previously, the setBuffer API was misused and the size of a new data
was passed instead of the size of data to replace.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Previously, the setBuffer API was misused and the size of a new data
was passed instead of the size of data to replace.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants