[Security Solution] [Detections] Updates warning message when no indices match provided index patterns by dhurley14 · Pull Request #93094 · elastic/kibana

dhurley14 · 2021-03-01T19:34:08Z

Summary

updates warning messages and modifies warning message when endpoint security rule is missing index pattern

Endpoint Security rule screenshot:

endpoint_security_rule_new_warning_message

New text for other rules:

Checklist

Delete any items that are not applicable to this PR.

For maintainers

This was checked for breaking API changes and was labeled appropriately

…ecurity rule is missing index pattern

elasticmachine · 2021-03-01T19:54:38Z

Pinging @elastic/security-solution (Team: SecuritySolution)

elasticmachine · 2021-03-01T19:54:39Z

Pinging @elastic/security-detections-response (Team:Detections and Resp)

spong

LGTM! Thanks @dhurley14! 🙂

kibanamachine · 2021-03-02T00:51:57Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 9d6e38d
Storybooks Preview
Flaky suites:
- xpack-securitySolutionCypressChrome

Test Failures

Kibana Pipeline / general / adds correctly a filter to the global search bar.SearchBar adds correctly a filter to the global search bar

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has failed 19 times on tracked branches: https://github.com/elastic/kibana/issues/69595

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="comboBoxOptionsList filterFieldSuggestionList-optionsList"] button[title="host.ip"] mark`, but never found it.
    at Object.fillAddFilterForm (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15733:8)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/header/search_bar.spec.ts:15036:22)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💔 Build #110048 failed b3241b0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

…ces match provided index patterns (elastic#93094) * updates warning messages and modifies warning message when endpoint security rule is missing index pattern * fix integration test text

kibanamachine · 2021-03-02T14:13:32Z

💔 Backport failed

❌ 7.11: Commit could not be cherrypicked due to conflicts
✅ 7.12 / #93221
✅ 7.x / #93223

Successful backport PRs will be merged automatically after passing CI.

To backport manually, check out the target branch and run:
node scripts/backport --pr 93094

…ces match provided index patterns (elastic#93094) * updates warning messages and modifies warning message when endpoint security rule is missing index pattern * fix integration test text # Conflicts: # x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts

…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)

…ces match provided index patterns (#93094) (#93223) * updates warning messages and modifies warning message when endpoint security rule is missing index pattern * fix integration test text Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>

…ces match provided index patterns (#93094) (#93221) * updates warning messages and modifies warning message when endpoint security rule is missing index pattern * fix integration test text Co-authored-by: Devin W. Hurley <devin.hurley@elastic.co>

* master: (199 commits) Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969) [Bazel] More resilient Workspace Status (elastic#93244) [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001) [Workplace Search] Role Mappings to Kibana (elastic#93123) [Fleet] Use type-only imports where possible (elastic#92979) [Lens] Set pie chart slices sorted clockwise (elastic#92617) Remove ms label from CPU load on status page (elastic#92836) [App Search] Migrate Create Meta Engine View (elastic#92127) [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917) [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) ...

…no indices match provided index patterns (#93094) (#93227) * [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094) * updates warning messages and modifies warning message when endpoint security rule is missing index pattern * fix integration test text # Conflicts: # x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_rules.ts * fix ftr test

updates warning messages and modifies warning message when endpoint s…

b3241b0

…ecurity rule is missing index pattern

dhurley14 self-assigned this Mar 1, 2021

dhurley14 marked this pull request as ready for review March 1, 2021 19:54

dhurley14 requested a review from a team as a code owner March 1, 2021 19:54

dhurley14 changed the title ~~[DRAFT] [Security Solution] [Detections] Updates warning message when no indices match provided index patterns~~ [Security Solution] [Detections] Updates warning message when no indices match provided index patterns Mar 1, 2021

spong approved these changes Mar 1, 2021

View reviewed changes

fix integration test text

9d6e38d

peluja1012 requested a review from a team March 2, 2021 10:03

dhurley14 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 2, 2021

dhurley14 merged commit 1bdf002 into elastic:master Mar 2, 2021

dhurley14 deleted the rule-warning-status-message branch March 2, 2021 14:11

kibanamachine mentioned this pull request Mar 2, 2021

[7.12] [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094) #93221

Merged

kibanamachine mentioned this pull request Mar 2, 2021

[7.x] [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094) #93223

Merged

dhurley14 mentioned this pull request Mar 2, 2021

[7.11] [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (#93094) #93227

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] [Detections] Updates warning message when no indices match provided index patterns#93094

[Security Solution] [Detections] Updates warning message when no indices match provided index patterns#93094
dhurley14 merged 2 commits intoelastic:masterfrom
dhurley14:rule-warning-status-message

dhurley14 commented Mar 1, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

spong left a comment

Uh oh!

kibanamachine commented Mar 2, 2021

Stack Trace

async chunk count

Uh oh!

kibanamachine commented Mar 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dhurley14 commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 2, 2021

💛 Build succeeded, but was flaky

Test Failures

Stack Trace

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

Uh oh!

kibanamachine commented Mar 2, 2021

💔 Backport failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dhurley14 commented Mar 1, 2021 •

edited

Loading