[ML] Transforms: Fixes chart histograms for runtime fields.#93028
Merged
walterra merged 5 commits intoelastic:masterfrom Mar 2, 2021
Merged
[ML] Transforms: Fixes chart histograms for runtime fields.#93028walterra merged 5 commits intoelastic:masterfrom
walterra merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
|
Tested and the extra validation LGTM. One small thing is I wasn't able to get histogram charts for the numeric and boolean runtime mapping to show up while testing.
|
Contributor
Author
Contributor
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
darnautov
reviewed
Mar 2, 2021
| type: 'numeric'; | ||
| } | ||
|
|
||
| export const isNumericChartData = (arg: any): arg is NumericChartData => { |
Contributor
There was a problem hiding this comment.
shall we use unknown instead of any for type guards?
Contributor
Author
There was a problem hiding this comment.
It's a good idea, but since we used any so far for all type guards, I'd rather do this in a follow up and change it for all type guards we have if we want to do it. There might be some changes necessary to how we check objects.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
…93028) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 2, 2021
…93028) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend.
Contributor
12 tasks
kibanamachine
added a commit
that referenced
this pull request
Mar 2, 2021
…93202) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Mar 2, 2021
…93203) Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a 0 documents legend. Co-authored-by: Walter Rafelsberger <walter@elastic.co>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 2, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #71231
Fixes chart histograms for runtime fields. The runtime field configurations were not passed on to the endpoint to fetch the charts data, so charts ended up being empty with a
0 documentslegend.ml/common/types/field_histograms.tsfor better reuse.runtimeMappingsSchematoapi_schemas/commonfor better reuse.Checklist