Skip to content

[Security Solution] - Bug fixes#92294

Merged
michaelolo24 merged 4 commits intoelastic:masterfrom
michaelolo24:bug-fixes
Mar 2, 2021
Merged

[Security Solution] - Bug fixes#92294
michaelolo24 merged 4 commits intoelastic:masterfrom
michaelolo24:bug-fixes

Conversation

@michaelolo24
Copy link
Copy Markdown
Contributor

@michaelolo24 michaelolo24 commented Feb 22, 2021 •
edited
Loading

@michaelolo24 michaelolo24 requested a review from a team as a code owner February 22, 2021 21:58
@michaelolo24 michaelolo24 added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v8.0.0 labels Feb 22, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 22, 2021

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 22, 2021

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@michaelolo24 michaelolo24 requested a review from a team February 22, 2021 22:10
michaelolo24
michaelolo24 commented Feb 22, 2021
View reviewed changes
x-pack/plugins/security_solution/public/timelines/components/side_panel/index.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@michaelolo24 michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change in this file was removing React.memo. It may be causing an issue where the event_details view isn't switching properly. The props to this component do not change when the expanded_detail changes, and as this is just a wrapper of memoized components, it's unnecessary.

michaelolo24
michaelolo24 commented Feb 22, 2021
View reviewed changes
x-pack/plugins/security_solution/public/timelines/components/side_panel/host_details/index.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@michaelolo24 michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes (same in network_details): #92004 (comment)

michaelolo24
michaelolo24 commented Feb 22, 2021
View reviewed changes
.../security_solution/public/timelines/components/side_panel/event_details/expandable_event.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@michaelolo24 michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes: #92004 (comment)

michaelolo24
michaelolo24 commented Feb 22, 2021
View reviewed changes
x-pack/plugins/security_solution/public/resolver/view/resolver_no_process_events.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@michaelolo24 michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There wasn't a bug filed for this yet, but when copying the text into the search bar it doesn't work unless you use double quotes.

michaelolo24
michaelolo24 commented Feb 22, 2021
View reviewed changes
...ugins/security_solution/public/overview/components/host_overview/endpoint_overview/index.tsx Outdated
Copy link
Copy Markdown
Contributor Author

@michaelolo24 michaelolo24 Feb 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were just about removing isInDetailsSidePanel. It isn't necessary for these components to be aware of this

@michaelolo24 michaelolo24 force-pushed the bug-fixes branch 2 times, most recently from 72f463f to 23bc30b Compare February 25, 2021 14:00
@michaelolo24
Copy link
Copy Markdown
Contributor Author

michaelolo24 commented Mar 1, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 1, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB -12.0B
triggersActionsUi 1.6MB 1.5MB -23.9KB
total -23.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 104.0KB 104.1KB +82.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 41 42 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jonathan-buttner
jonathan-buttner approved these changes Mar 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonathan-buttner jonathan-buttner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down and tested that the different panel titles didn't overlap and that the indices were populated 👍

...ns/security_solution/public/timelines/components/side_panel/host_details/expandable_host.tsx
const { to, from, isInitializing } = useGlobalTime();
const { docValueFields, selectedPatterns } = useSourcererScope();
const { docValueFields } = useSourcererScope();
/*
Copy link
Copy Markdown
Contributor

@jonathan-buttner jonathan-buttner Mar 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great comment 👍

kqualters-elastic
kqualters-elastic approved these changes Mar 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visually verified locally lgtm 👍

@michaelolo24 michaelolo24 merged commit 3c4a3b8 into elastic:master Mar 2, 2021
@michaelolo24 michaelolo24 deleted the bug-fixes branch March 2, 2021 13:37
@michaelolo24 michaelolo24 mentioned this pull request Mar 2, 2021
Merged
@michaelolo24 michaelolo24 mentioned this pull request Mar 2, 2021
Merged
michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Mar 2, 2021
@michaelolo24 @kibanamachine
[Security Solution] - Bug fixes (elastic#92294)
530d788 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
michaelolo24 added a commit to michaelolo24/kibana that referenced this pull request Mar 2, 2021
@michaelolo24 @kibanamachine
[Security Solution] - Bug fixes (elastic#92294)
7249494 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 2, 2021
@gmmorris
Merge branch 'task-manager/docs-monitoring' of github.com:gmmorris/ki…
0a85947 
…bana into task-manager/docs-monitoring

* 'task-manager/docs-monitoring' of github.com:gmmorris/kibana:
  [ILM] Allow multiple searchable snapshot actions (elastic#92789)
  Improve consistency for display of management items (elastic#92694)
  skip flaky suite (elastic#93152)
  skip flaky suite (elastic#93152)
  [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826)
  Add developer documentation about the building blocks we offer plugin developers (elastic#92743)
  [Security Solution] Case ui enhancement (elastic#91863)
  [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094)
  Collect agent telemetry even when fleet server is disabled. (elastic#93198)
  [Lens] Fix runtime validation error message (elastic#93195)
  [Lens] Remove warning about ordinal x-domain (elastic#93049)
  [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150)
  Cleanup Security plugin imports (elastic#93056)
  [Security Solution] - Bug fixes (elastic#92294)
  Updated doc links (elastic#92968)
  [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028)
  [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
michaelolo24 added a commit that referenced this pull request Mar 2, 2021
@michaelolo24 @kibanamachine
[Security Solution] - Bug fixes (#92294) (#93208)
9955355 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
michaelolo24 added a commit that referenced this pull request Mar 2, 2021
@michaelolo24 @kibanamachine
[Security Solution] - Bug fixes (#92294) (#93209)
cfbd64f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-buttner jonathan-buttner jonathan-buttner approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michaelolo24 @elasticmachine @kibanamachine @jonathan-buttner @kqualters-elastic