[Enterprise Search] Updated doc links to use dynamic prefixes#92968
Merged
JasonStoltz merged 2 commits intoelastic:masterfrom Mar 2, 2021
Merged
[Enterprise Search] Updated doc links to use dynamic prefixes#92968JasonStoltz merged 2 commits intoelastic:masterfrom
JasonStoltz merged 2 commits intoelastic:masterfrom
Conversation
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
scottybollinger
approved these changes
Mar 1, 2021
Contributor
scottybollinger
left a comment
There was a problem hiding this comment.
LGTM from Workplace Search. Verified the new links work. Thanks for knocking this out!
cee-chen
approved these changes
Mar 1, 2021
Contributor
cee-chen
left a comment
There was a problem hiding this comment.
Thanks for catching this Jason!
cee-chen
reviewed
Mar 1, 2021
| import { FormattedMessage } from '@kbn/i18n/react'; | ||
|
|
||
| import { ENTERPRISE_SEARCH_PLUGIN } from '../../../../../common/constants'; | ||
| import { DOCS_PREFIX } from '../../../app_search/routes'; |
Contributor
There was a problem hiding this comment.
Although as a quick note on this - whenever @chriscressman changes our docs, we should update our Setup Guide links to link out to a single shared Enterprise Search authentication doc page instead of using AS/WS specific auth docs
Contributor
kibanamachine
added a commit
that referenced
this pull request
Mar 2, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 2, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed a couple of places where we were not using dynamic doc links. I can't think of any reason why we'd want this, so I updated them to use the dynamic prefixes.
For maintainers