Cleanup Security plugin imports#93056
Merged
jportner merged 14 commits intoelastic:masterfrom Mar 2, 2021
Merged
Conversation
This is needed to use the import sorter
Sort order 1. External dependencies 2. Internal absolute dependencies (@kbn/..., src/...) 3. Internal relative dependencies
Adds ESLint rule to enforce this.
Adds ESLint rule to enforce this.
Adds ESLint rule to enforce this.
Also got rid of imports from `'kibana/...'` in favor of `'src/core/...'`. For some reason a couple of Jest tests broke (snapshots had unnecessary whitespace which is automatically removed by ESLint). I modified the test assertions to tighten them up so the snapshots pass.
This is needed to use the import sorter
Some modules had relative imports outside of the directory when they should not, or exports from the server when they should import directly from common.
Sort order 1. External dependencies 2. Internal absolute dependencies (@kbn/..., src/...) 3. Internal relative dependencies
Adds ESLint rule to enforce this.
4335dda to
442dcdd
Compare
jportner
commented
Mar 1, 2021
| # Security | ||
| /src/core/server/csp/ @elastic/kibana-security @elastic/kibana-core | ||
| /src/plugins/security_oss/ @elastic/kibana-security | ||
| /src/plugins/spaces_oss/ @elastic/kibana-security |
Contributor
Author
There was a problem hiding this comment.
I noticed this was missing, so I added it 🙈
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
legrego
approved these changes
Mar 2, 2021
Member
legrego
left a comment
There was a problem hiding this comment.
LGTM - Thanks for the cleanup work!
| # Security | ||
| /src/core/server/csp/ @elastic/kibana-security @elastic/kibana-core | ||
| /src/plugins/security_oss/ @elastic/kibana-security | ||
| /src/plugins/spaces_oss/ @elastic/kibana-security |
Contributor
💔 Backport failed❌ 7.x: Commit could not be cherrypicked due to conflicts To backport manually, check out the target branch and run: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 2, 2021
…bana into task-manager/docs-monitoring * 'task-manager/docs-monitoring' of github.com:gmmorris/kibana: [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) [Security Solution] Fixes the Customize Event Renderers modal by removing the EuiOverlayMask (elastic#93150) Cleanup Security plugin imports (elastic#93056) [Security Solution] - Bug fixes (elastic#92294) Updated doc links (elastic#92968) [ML] Transforms: Fixes chart histograms for runtime fields. (elastic#93028) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086)
jportner
added a commit
that referenced
this pull request
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on to #91976.
Cleans up imports for the following plugins:
Sort order
Each of these plugins also now requires consistent type imports (the
import typedirective), and I've converted relative imports to (internal) absolute imports where possible.