[Discover] Change icon of saved search in open search panel and embeddable selection#93001
Merged
kertal merged 4 commits intoelastic:masterfrom Mar 2, 2021
Conversation
Contributor
|
@elasticmachine merge upstream |
…saved-search-icon
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
reviewed
Mar 2, 2021
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Seems like this place has to be fixed as well:
…icon' of github.com:kertal/kibana into kertal-pr-2021-01-01-discover-change-open-saved-search-icon
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/create_threat_matching·ts.detection engine api security and spaces enabled create_threat_matching tests with auditbeat data indicator enrichment generates multiple signals with multiple matchesStandard OutStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @kertal |
flash1293
approved these changes
Mar 2, 2021
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested and all places I found look the same now, LGTM
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 2, 2021
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Mar 2, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 2, 2021
* master: (199 commits) Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969) [Bazel] More resilient Workspace Status (elastic#93244) [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001) [Workplace Search] Role Mappings to Kibana (elastic#93123) [Fleet] Use type-only imports where possible (elastic#92979) [Lens] Set pie chart slices sorted clockwise (elastic#92617) Remove ms label from CPU load on status page (elastic#92836) [App Search] Migrate Create Meta Engine View (elastic#92127) [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917) [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR changes the icon type of the
Open search paneland embeddable selection toDiscoverApp, to align it with the icon displayed inSaved Objectsmanagement and prevent confusion with theSaved Querytype. Before this PR thecompassicon was displayed here (This is the icon ofSaved Query)Old:
New:
Embeddable Selection New:
Fixes #93000