[App Search] Migrate Create Meta Engine View by byronhulcher · Pull Request #92127 · elastic/kibana

byronhulcher · 2021-02-22T03:18:36Z

Summary

This PR migrates the Create Meta Engine view from ent-search, with improved test coverage and no custom STUI components.

Screenshots

Engines Overview: No meta engines

Engines Overview: Some meta engines

Meta Engine Creation Form: Blank

Meta Engine Creation Form: Invalid name

Meta Engine Creation Form: Valid name, no source engines

Meta Engine Creation Form: Valid name, Too many source engines

Meta Engine Creation Form: Valid name, valid source engines

Meta Engine Creation Form: API error state

Engine Overview: After meta engine creation

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

byronhulcher · 2021-02-22T03:19:34Z

~~TODO~~ ~~TO-DONE!~~

I just realized we will probably need to change not showing the meta engines section when meta engines length === 0. On a platinum license, we'll always want to show the meta section so the create button is actually available. Additionally we'll likely want some kind of EuiEmptyPrompt CTA.

…EngineCreationLogic

… to MetaEngineCreationLogic

…ionLogic

...public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts

...c/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.test.ts

cee-chen · 2021-02-24T19:52:11Z

OK sorry for the millions of separate comments, I think that's it for my first review pass! #92127 (comment) is probably the biggest one / will cause some annoying cascading waterfall changes in tests etc.

QA also looks and feels great, awesome work on this Byron!

...terprise_search/public/applications/app_search/components/meta_engine_creation/constants.tsx

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

byronhulcher · 2021-03-01T15:40:33Z

Hey @constancecchen I think this is ready for another round 💪

cee-chen

Changes look great! I'm good to approve once these two remaining threads are resolved (through more chatting/discussion/agreeing to disagree is fine!):

#92127 (comment)
#92127 (comment)

…h/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

...public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts

…h/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

…h/components/engines/constants.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen

Thanks for resolving the last few comments! CI failures look unrelated/flakey, hopefully they don't come up again in the rerun 🤞

kibanamachine · 2021-03-01T22:51:53Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`enterpriseSearch`	1281	1285	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`enterpriseSearch`	1.9MB	2.0MB	+12.7KB
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB
total			-11.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💔 Build #110051 failed bd7a05f
💔 Build #110036 failed 16a07f3
💚 Build #109942 succeeded e9adff2
💔 Build #109925 failed 49b35be04392564539d41e7143a28c9adaa3f283
💔 Build #109602 failed 31070ee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cee-chen · 2021-03-02T16:20:22Z

@byronhulcher Apologies if I'm stepping on your toes while you're out - merging this on your behalf while you're out today so that you don't have to re-run Kibana CI when you get back and so I can address the = branch in #92841. If you don't prefer people to merge PRs for you definitely please let me know/yell at me when you get back!

* New empty MetaEngineCreation component * Added MetaEngineCreation to AppSearchConfigured router * Empty MetaEngineCreationLogic * Add rawName value and setRawName action to MetaEngineCreationLogic * Add indexedEngineNames value and setIndexedEngineNames action to MEtaEngineCreationLogic * Add selectedIndexedEngineNames value and setIndexedEngineNames action to MetaEngineCreationLogic * Add description to MetaEngineCreation * Add name selector to MetaEngineCreationLogic * Added MetaEngineCreationNameInput to MetaEngineCreation * Add fetchIndexedEngineNames listener to MetaEngineCreationLogic * Call fetchIndexedEngineNames when MetaEngineCreation first renders * Add EuiComboBox for selectedEngineNames to MetaEngineCreation * WIP Add meta engine source engine limit warning to MetaEngineCreation * Add submitEngine listener to MetaEngineCreationLogic * Add onEngineCreationSuccess to MetaEngineCreationLogic * Fixing tests for MetaEngineCreationLogic * Fix tests for MetaEngineCreation * Add Create a meta engine button to EnginesOverview * Use DEFAULT_META for fetching indexed engine names in MetaEngineCreationLogic * Copy fixes * Updating POST /api/engines tests * Add noItemsMessage prop to EnginesTable * Add empty prompt to Meta Engines table in EnginesOverview * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Better form functionality in MetaEngineCreation * Fix errors from github * More MetaEngineCreation coverage * Meta MetaEngineCreationLogic coverage * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/constants.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>

kibanamachine · 2021-03-02T16:26:16Z

💚 Backport successful

✅ 7.x / #93256

Successful backport PRs will be merged automatically after passing CI.

* master: (199 commits) Convert Canvas docs to MDX for use in Elastic Docs (elastic#91969) [Bazel] More resilient Workspace Status (elastic#93244) [Discover] Change icon of saved search in open search panel and embeddable selection (elastic#93001) [Workplace Search] Role Mappings to Kibana (elastic#93123) [Fleet] Use type-only imports where possible (elastic#92979) [Lens] Set pie chart slices sorted clockwise (elastic#92617) Remove ms label from CPU load on status page (elastic#92836) [App Search] Migrate Create Meta Engine View (elastic#92127) [Time to Visualize] Disable Visualize URL Tracker When Linked to OriginatingApp (elastic#92917) [ILM] Allow multiple searchable snapshot actions (elastic#92789) Improve consistency for display of management items (elastic#92694) skip flaky suite (elastic#93152) skip flaky suite (elastic#93152) [ILM] Refactor edit_policy client integration tests into separate feature files (elastic#92826) Add developer documentation about the building blocks we offer plugin developers (elastic#92743) [Security Solution] Case ui enhancement (elastic#91863) [Security Solution] [Detections] Updates warning message when no indices match provided index patterns (elastic#93094) Collect agent telemetry even when fleet server is disabled. (elastic#93198) [Lens] Fix runtime validation error message (elastic#93195) [Lens] Remove warning about ordinal x-domain (elastic#93049) ...

* New empty MetaEngineCreation component * Added MetaEngineCreation to AppSearchConfigured router * Empty MetaEngineCreationLogic * Add rawName value and setRawName action to MetaEngineCreationLogic * Add indexedEngineNames value and setIndexedEngineNames action to MEtaEngineCreationLogic * Add selectedIndexedEngineNames value and setIndexedEngineNames action to MetaEngineCreationLogic * Add description to MetaEngineCreation * Add name selector to MetaEngineCreationLogic * Added MetaEngineCreationNameInput to MetaEngineCreation * Add fetchIndexedEngineNames listener to MetaEngineCreationLogic * Call fetchIndexedEngineNames when MetaEngineCreation first renders * Add EuiComboBox for selectedEngineNames to MetaEngineCreation * WIP Add meta engine source engine limit warning to MetaEngineCreation * Add submitEngine listener to MetaEngineCreationLogic * Add onEngineCreationSuccess to MetaEngineCreationLogic * Fixing tests for MetaEngineCreationLogic * Fix tests for MetaEngineCreation * Add Create a meta engine button to EnginesOverview * Use DEFAULT_META for fetching indexed engine names in MetaEngineCreationLogic * Copy fixes * Updating POST /api/engines tests * Add noItemsMessage prop to EnginesTable * Add empty prompt to Meta Engines table in EnginesOverview * Apply suggestions from code review Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Better form functionality in MetaEngineCreation * Fix errors from github * More MetaEngineCreation coverage * Meta MetaEngineCreationLogic coverage * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> * Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/constants.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com> Co-authored-by: Byron Hulcher <byronhulcher@gmail.com> Co-authored-by: Constance <constancecchen@users.noreply.github.com>

byronhulcher · 2021-03-08T15:26:25Z

Hey @constancecchen sorry I left this unmerged before I left, last week was a bit of a blur. I appreciate you merging it, and I'll follow up the leftovers.

byronhulcher added 21 commits February 23, 2021 14:54

New empty MetaEngineCreation component

d436c4b

Added MetaEngineCreation to AppSearchConfigured router

cd05bc7

Empty MetaEngineCreationLogic

eba36a2

Add rawName value and setRawName action to MetaEngineCreationLogic

1dc3e90

Add indexedEngineNames value and setIndexedEngineNames action to MEta…

6627d24

…EngineCreationLogic

Add selectedIndexedEngineNames value and setIndexedEngineNames action…

ebaff11

… to MetaEngineCreationLogic

Add description to MetaEngineCreation

a780e1b

Add name selector to MetaEngineCreationLogic

369d82a

Added MetaEngineCreationNameInput to MetaEngineCreation

76f88c0

Add fetchIndexedEngineNames listener to MetaEngineCreationLogic

6dfc1bd

Call fetchIndexedEngineNames when MetaEngineCreation first renders

6c42c62

Add EuiComboBox for selectedEngineNames to MetaEngineCreation

200802e

WIP Add meta engine source engine limit warning to MetaEngineCreation

753bad1

Add submitEngine listener to MetaEngineCreationLogic

c999341

Add onEngineCreationSuccess to MetaEngineCreationLogic

23805ed

Fixing tests for MetaEngineCreationLogic

41da254

Fix tests for MetaEngineCreation

3047390

Add Create a meta engine button to EnginesOverview

6bae359

Use DEFAULT_META for fetching indexed engine names in MetaEngineCreat…

04b371f

…ionLogic

Copy fixes

1c1cc8e

Updating POST /api/engines tests

0423d9e

byronhulcher force-pushed the meta-engine-creation branch 2 times, most recently from c91fede to 0423d9e Compare February 24, 2021 15:18

byronhulcher marked this pull request as ready for review February 24, 2021 15:25

byronhulcher requested a review from a team February 24, 2021 15:25

byronhulcher added release_note:skip Skip the PR/issue when compiling release notes v7.13.0 labels Feb 24, 2021

byronhulcher added 2 commits February 24, 2021 10:51

Add noItemsMessage prop to EnginesTable

f7741eb

Add empty prompt to Meta Engines table in EnginesOverview

2cd7cd1

cee-chen reviewed Feb 24, 2021

View reviewed changes

...public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Show resolved Hide resolved

cee-chen reviewed Feb 24, 2021

View reviewed changes

...c/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.test.ts Show resolved Hide resolved

cee-chen reviewed Feb 24, 2021

View reviewed changes

...c/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.test.ts Show resolved Hide resolved

byronhulcher commented Feb 25, 2021

View reviewed changes

...terprise_search/public/applications/app_search/components/meta_engine_creation/constants.tsx Outdated Show resolved Hide resolved

byronhulcher and others added 5 commits February 25, 2021 15:59

Apply suggestions from code review

31070ee

Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Better form functionality in MetaEngineCreation

61b83f8

Fix errors from github

4a012ce

More MetaEngineCreation coverage

4736433

Meta MetaEngineCreationLogic coverage

65e931c

byronhulcher force-pushed the meta-engine-creation branch from 49b35be to 65e931c Compare March 1, 2021 15:38

Merge remote-tracking branch 'origin/master' into meta-engine-creation

e9adff2

byronhulcher requested a review from cee-chen March 1, 2021 15:40

cee-chen reviewed Mar 1, 2021

View reviewed changes

Update x-pack/plugins/enterprise_search/public/applications/app_searc…

16a07f3

…h/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen reviewed Mar 1, 2021

View reviewed changes

...public/applications/app_search/components/meta_engine_creation/meta_engine_creation_logic.ts Outdated Show resolved Hide resolved

byronhulcher and others added 2 commits March 1, 2021 14:37

Update x-pack/plugins/enterprise_search/public/applications/app_searc…

bd7a05f

…h/components/meta_engine_creation/meta_engine_creation_logic.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

Update x-pack/plugins/enterprise_search/public/applications/app_searc…

6ca7a26

…h/components/engines/constants.ts Co-authored-by: Constance <constancecchen@users.noreply.github.com>

cee-chen approved these changes Mar 1, 2021

View reviewed changes

cee-chen mentioned this pull request Mar 1, 2021

[App Search] Refactor AppLogic to initialize data via props rather than action #92841

Merged

2 tasks

cee-chen merged commit 3d06573 into elastic:master Mar 2, 2021

kibanamachine mentioned this pull request Mar 2, 2021

[7.x] [App Search] Migrate Create Meta Engine View (#92127) #93256

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[App Search] Migrate Create Meta Engine View#92127

[App Search] Migrate Create Meta Engine View#92127
cee-chen merged 32 commits intoelastic:masterfrom
byronhulcher:meta-engine-creation

byronhulcher commented Feb 22, 2021 •

edited

Loading

Uh oh!

byronhulcher commented Feb 22, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cee-chen commented Feb 24, 2021

Uh oh!

Uh oh!

byronhulcher commented Mar 1, 2021

Uh oh!

cee-chen left a comment •

edited

Loading

Uh oh!

Uh oh!

cee-chen left a comment

Uh oh!

kibanamachine commented Mar 1, 2021

async chunk count

Uh oh!

cee-chen commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

Uh oh!

byronhulcher commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

byronhulcher commented Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Engines Overview: No meta engines

Engines Overview: Some meta engines

Meta Engine Creation Form: Blank

Meta Engine Creation Form: Invalid name

Meta Engine Creation Form: Valid name, no source engines

Meta Engine Creation Form: Valid name, Too many source engines

Meta Engine Creation Form: Valid name, valid source engines

Meta Engine Creation Form: API error state

Engine Overview: After meta engine creation

Checklist

Uh oh!

byronhulcher commented Feb 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cee-chen commented Feb 24, 2021

Uh oh!

Uh oh!

byronhulcher commented Mar 1, 2021

Uh oh!

cee-chen left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cee-chen left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 1, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

History

Uh oh!

cee-chen commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

💚 Backport successful

Uh oh!

byronhulcher commented Mar 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

byronhulcher commented Feb 22, 2021 •

edited

Loading

byronhulcher commented Feb 22, 2021 •

edited

Loading

cee-chen left a comment •

edited

Loading