## Summary
In the past months, the capture OAS snapshot step has been quite flaky,
breaking the `Checks` step, and thus breaking the `on-merge` jobs.

This PR extracts the check to its own step and adds retries. The
separate step is ideal because it is quite heavy compared to the other
checks (we fire up ES + Kibana for the OAS snapshot).

Also, this PR removes the `Checks` step altogether from the
kibana-chrome-forward-testing pipeline, as the Chrome versions used do
not affect that aspect.

This test run includes a retry within the Capture OAS Snapshot step:
https://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea

(cherry picked from commit 2fbc843)

# Conflicts:
#	.buildkite/pipelines/chrome_forward_testing.yml

## Summary
In the past months, the capture OAS snapshot step has been quite flaky,
breaking the `Checks` step, and thus breaking the `on-merge` jobs.

This PR extracts the check to its own step and adds retries. The
separate step is ideal because it is quite heavy compared to the other
checks (we fire up ES + Kibana for the OAS snapshot).

Also, this PR removes the `Checks` step altogether from the
kibana-chrome-forward-testing pipeline, as the Chrome versions used do
not affect that aspect.

This test run includes a retry within the Capture OAS Snapshot step:
https://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea

(cherry picked from commit 2fbc843)

# Conflicts:
#	.buildkite/pipelines/chrome_forward_testing.yml

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ci] Extract OAS check + add retry
(#196534)](#196534)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-10-17T13:03:28Z","message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"number":196534,"url":"https://github.com/elastic/kibana/pull/196534","mergeCommit":{"message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196534","number":196534,"mergeCommit":{"message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402"}}]}]
BACKPORT-->

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ci] Extract OAS check + add retry
(#196534)](#196534)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-10-17T13:03:28Z","message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","v9.0.0","backport:prev-major"],"number":196534,"url":"https://github.com/elastic/kibana/pull/196534","mergeCommit":{"message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196534","number":196534,"mergeCommit":{"message":"[ci]
Extract OAS check + add retry (#196534)\n\n## Summary\r\nIn the past
months, the capture OAS snapshot step has been quite flaky,\r\nbreaking
the `Checks` step, and thus breaking the `on-merge` jobs.\r\n\r\nThis PR
extracts the check to its own step and adds retries. The\r\nseparate
step is ideal because it is quite heavy compared to the other\r\nchecks
(we fire up ES + Kibana for the OAS snapshot).\r\n\r\nAlso, this PR
removes the `Checks` step altogether from
the\r\nkibana-chrome-forward-testing pipeline, as the Chrome versions
used do\r\nnot affect that aspect.\r\n\r\nThis test run includes a retry
within the Capture OAS Snapshot
step:\r\nhttps://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea","sha":"2fbc843e0d6925a63e9bafdcab38ba7dffac1402"}}]}]
BACKPORT-->

It's not an actual dependency of downstream steps, but was added more to
provide as a cost cutting gate. However, there are times it delays
downstream steps without any added value.

Here's the provenance for `check_oas_snapshot` in the pull-request
pipeline.

### 1. OAS snapshot capture first added to CI (inside "Checks")

- [PR #183338](#183338) / commit
[`975eeed255d0`](975eeed255d0)
(May 30, 2024) —
 "[HTTP/OAS] Commit OAS snapshot"
- Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it
into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the
Checks step, not a
standalone pipeline step yet).

### 2. Standalone "Check OAS Snapshot" step added to PR pipeline

- [PR #196534](#196534) / commit
[`2fbc843e0d69`](2fbc843e0d69)
(Oct 17, 2024) —
 "[ci] Extract OAS check + add retry"
- Motivation (from the PR summary): the capture step was flaky and was
breaking Checks; they extracted it into its own heavy step (starts
ES+Kibana) and added
retries.
- This is where it gets added as its own step in
`.buildkite/pipelines/pull_request/base.yml`, running
`.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`.

### 3. `depends_on: check_oas_snapshot` added across PR test suite
pipelines

- [PR #198452](#198452) / commit
[`cbb211abe0cd`](cbb211abe0cd)
(Nov 4, 2024) —
"[ci] Run checks before tests"
- This commit added `key: check_oas_snapshot` in
`.buildkite/pipelines/pull_request/base.yml` and updated many PR suite
pipeline YAMLs to depend on it (and on
`checks`) before running.
- Example change: `.buildkite/pipelines/pull_request/response_ops.yml`
adds `- check_oas_snapshot` under `depends_on` in that commit.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

It's not an actual dependency of downstream steps, but was added more to
provide as a cost cutting gate. However, there are times it delays
downstream steps without any added value.

Here's the provenance for `check_oas_snapshot` in the pull-request
pipeline.

### 1. OAS snapshot capture first added to CI (inside "Checks")

- [PR elastic#183338](elastic#183338) / commit
[`975eeed255d0`](elastic@975eeed255d0)
(May 30, 2024) —
 "[HTTP/OAS] Commit OAS snapshot"
- Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it
into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the
Checks step, not a
standalone pipeline step yet).

### 2. Standalone "Check OAS Snapshot" step added to PR pipeline

- [PR elastic#196534](elastic#196534) / commit
[`2fbc843e0d69`](elastic@2fbc843e0d69)
(Oct 17, 2024) —
 "[ci] Extract OAS check + add retry"
- Motivation (from the PR summary): the capture step was flaky and was
breaking Checks; they extracted it into its own heavy step (starts
ES+Kibana) and added
retries.
- This is where it gets added as its own step in
`.buildkite/pipelines/pull_request/base.yml`, running
`.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`.

### 3. `depends_on: check_oas_snapshot` added across PR test suite
pipelines

- [PR elastic#198452](elastic#198452) / commit
[`cbb211abe0cd`](elastic@cbb211abe0cd)
(Nov 4, 2024) —
"[ci] Run checks before tests"
- This commit added `key: check_oas_snapshot` in
`.buildkite/pipelines/pull_request/base.yml` and updated many PR suite
pipeline YAMLs to depend on it (and on
`checks`) before running.
- Example change: `.buildkite/pipelines/pull_request/response_ops.yml`
adds `- check_oas_snapshot` under `depends_on` in that commit.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

It's not an actual dependency of downstream steps, but was added more to
provide as a cost cutting gate. However, there are times it delays
downstream steps without any added value.

Here's the provenance for `check_oas_snapshot` in the pull-request
pipeline.

### 1. OAS snapshot capture first added to CI (inside "Checks")

- [PR elastic#183338](elastic#183338) / commit
[`975eeed255d0`](elastic@975eeed255d0)
(May 30, 2024) —
 "[HTTP/OAS] Commit OAS snapshot"
- Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it
into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the
Checks step, not a
standalone pipeline step yet).

### 2. Standalone "Check OAS Snapshot" step added to PR pipeline

- [PR elastic#196534](elastic#196534) / commit
[`2fbc843e0d69`](elastic@2fbc843e0d69)
(Oct 17, 2024) —
 "[ci] Extract OAS check + add retry"
- Motivation (from the PR summary): the capture step was flaky and was
breaking Checks; they extracted it into its own heavy step (starts
ES+Kibana) and added
retries.
- This is where it gets added as its own step in
`.buildkite/pipelines/pull_request/base.yml`, running
`.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`.

### 3. `depends_on: check_oas_snapshot` added across PR test suite
pipelines

- [PR elastic#198452](elastic#198452) / commit
[`cbb211abe0cd`](elastic@cbb211abe0cd)
(Nov 4, 2024) —
"[ci] Run checks before tests"
- This commit added `key: check_oas_snapshot` in
`.buildkite/pipelines/pull_request/base.yml` and updated many PR suite
pipeline YAMLs to depend on it (and on
`checks`) before running.
- Example change: `.buildkite/pipelines/pull_request/response_ops.yml`
adds `- check_oas_snapshot` under `depends_on` in that commit.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>