Merged
Conversation
Escaped backslash characters Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
Starting backport for target branches: 8.x |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2024
## Summary To PR fix the problem with string escaping, we need to ensure that backslashes are properly escaped in addition to double quotes. Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> (cherry picked from commit 9ddf0e1)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ESQL] String escaping fix (#196643)](#196643) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T11:37:05Z","message":"[ESQL] String escaping fix (#196643)\n\n## Summary\r\n\r\nTo PR fix the problem with string escaping, we need to ensure that\r\nbackslashes are properly escaped in addition to double quotes.\r\n\r\nCo-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>","sha":"9ddf0e11ef0e004ccf9002061e9191c7739d9eb6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:ESQL"],"title":"[ESQL] String escaping fix","number":196643,"url":"https://github.com/elastic/kibana/pull/196643","mergeCommit":{"message":"[ESQL] String escaping fix (#196643)\n\n## Summary\r\n\r\nTo PR fix the problem with string escaping, we need to ensure that\r\nbackslashes are properly escaped in addition to double quotes.\r\n\r\nCo-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>","sha":"9ddf0e11ef0e004ccf9002061e9191c7739d9eb6"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196643","number":196643,"mergeCommit":{"message":"[ESQL] String escaping fix (#196643)\n\n## Summary\r\n\r\nTo PR fix the problem with string escaping, we need to ensure that\r\nbackslashes are properly escaped in addition to double quotes.\r\n\r\nCo-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>","sha":"9ddf0e11ef0e004ccf9002061e9191c7739d9eb6"}}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the problem with string escaping, we need to ensure that backslashes are properly escaped in addition to double quotes.