Skip to content

Commit cbb211a

Browse files
jbudzjbudz
authored
[ci] Run checks before tests (#198452)
Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
1 parent 744ddaf commit cbb211a

28 files changed

+138
-51
lines changed

‎.buildkite/pipelines/on_merge.yml‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,20 @@ steps:
4545
- exit_status: '-1'
4646
limit: 3
4747

48+
- command: .buildkite/scripts/steps/checks.sh
49+
label: 'Checks'
50+
agents:
51+
image: family/kibana-ubuntu-2004
52+
imageProject: elastic-images-prod
53+
provider: gcp
54+
machineType: n2-standard-2
55+
preemptible: true
56+
timeout_in_minutes: 60
57+
retry:
58+
automatic:
59+
- exit_status: '-1'
60+
limit: 3
61+
4862
- command: .buildkite/scripts/steps/lint.sh
4963
label: 'Linting'
5064
agents:
@@ -89,6 +103,20 @@ steps:
89103
- exit_status: '-1'
90104
limit: 3
91105

106+
- command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
107+
label: 'Check OAS Snapshot'
108+
agents:
109+
image: family/kibana-ubuntu-2004
110+
imageProject: elastic-images-prod
111+
provider: gcp
112+
machineType: n2-standard-4
113+
preemptible: true
114+
timeout_in_minutes: 60
115+
retry:
116+
automatic:
117+
- exit_status: '-1'
118+
limit: 3
119+
92120
- wait
93121

94122
- command: .buildkite/scripts/steps/on_merge_api_docs.sh
@@ -454,34 +482,6 @@ steps:
454482
provider: gcp
455483
machineType: n2-standard-2
456484

457-
- command: .buildkite/scripts/steps/checks.sh
458-
label: 'Checks'
459-
agents:
460-
image: family/kibana-ubuntu-2004
461-
imageProject: elastic-images-prod
462-
provider: gcp
463-
machineType: n2-standard-2
464-
preemptible: true
465-
timeout_in_minutes: 60
466-
retry:
467-
automatic:
468-
- exit_status: '-1'
469-
limit: 3
470-
471-
- command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
472-
label: 'Check OAS Snapshot'
473-
agents:
474-
image: family/kibana-ubuntu-2004
475-
imageProject: elastic-images-prod
476-
provider: gcp
477-
machineType: n2-standard-4
478-
preemptible: true
479-
timeout_in_minutes: 60
480-
retry:
481-
automatic:
482-
- exit_status: '-1'
483-
limit: 3
484-
485485
- command: .buildkite/scripts/steps/storybooks/build_and_upload.sh
486486
label: 'Build Storybooks'
487487
agents:

‎.buildkite/pipelines/pull_request/apm_cypress.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 120
1416
parallelism: 1 # TODO: Set parallelism when apm_cypress handles it
1517
retry:

‎.buildkite/pipelines/pull_request/base.yml‎

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,18 @@ steps:
3232
- exit_status: '-1'
3333
limit: 3
3434

35+
- command: .buildkite/scripts/steps/checks.sh
36+
label: 'Checks'
37+
key: checks
38+
agents:
39+
machineType: n2-standard-2
40+
preemptible: true
41+
timeout_in_minutes: 60
42+
retry:
43+
automatic:
44+
- exit_status: '-1'
45+
limit: 3
46+
3547
- command: .buildkite/scripts/steps/lint.sh
3648
label: 'Linting'
3749
agents:
@@ -56,6 +68,18 @@ steps:
5668
- exit_status: '-1'
5769
limit: 3
5870

71+
- command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
72+
label: 'Check OAS Snapshot'
73+
agents:
74+
machineType: n2-standard-4
75+
preemptible: true
76+
key: check_oas_snapshot
77+
timeout_in_minutes: 60
78+
retry:
79+
automatic:
80+
- exit_status: '-1'
81+
limit: 3
82+
5983
- command: .buildkite/scripts/steps/check_types.sh
6084
label: 'Check Types'
6185
agents:
@@ -99,29 +123,6 @@ steps:
99123
- exit_status: '*'
100124
limit: 1
101125

102-
- command: .buildkite/scripts/steps/checks.sh
103-
label: 'Checks'
104-
key: checks
105-
agents:
106-
machineType: n2-standard-2
107-
preemptible: true
108-
timeout_in_minutes: 60
109-
retry:
110-
automatic:
111-
- exit_status: '-1'
112-
limit: 3
113-
114-
- command: .buildkite/scripts/steps/checks/capture_oas_snapshot.sh
115-
label: 'Check OAS Snapshot'
116-
agents:
117-
machineType: n2-standard-4
118-
preemptible: true
119-
timeout_in_minutes: 60
120-
retry:
121-
automatic:
122-
- exit_status: '-1'
123-
limit: 3
124-
125126
- command: .buildkite/scripts/steps/api_docs/build_api_docs.sh
126127
label: 'Build API Docs'
127128
agents:

‎.buildkite/pipelines/pull_request/deploy_cloud.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 30
1416
soft_fail: true
1517
retry:

‎.buildkite/pipelines/pull_request/exploratory_view_plugin.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 60
1416
artifact_paths:
1517
- 'x-pack/plugins/observability_solution/exploratory_view/e2e/.journeys/**/*'

‎.buildkite/pipelines/pull_request/fips.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 60
1416
soft_fail: true
1517
retry:

‎.buildkite/pipelines/pull_request/fleet_cypress.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 50
1416
parallelism: 6
1517
retry:

‎.buildkite/pipelines/pull_request/inventory_cypress.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 120
1416
parallelism: 1
1517
retry:

‎.buildkite/pipelines/pull_request/kbn_handlebars.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 5
1416
retry:
1517
automatic:

‎.buildkite/pipelines/pull_request/observability_onboarding_cypress.yml‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@ steps:
77
depends_on:
88
- build
99
- quick_checks
10+
- checks
1011
- linting
1112
- linting_with_types
1213
- check_types
14+
- check_oas_snapshot
1315
timeout_in_minutes: 120
1416
retry:
1517
automatic:

0 commit comments

Comments
 (0)