Merged
Conversation
Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
Ikuni17
approved these changes
Nov 4, 2024
Contributor
|
Starting backport for target branches: 8.15, 8.16, 8.x |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 4, 2024
Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 4, 2024
Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 4, 2024
Should be the last group to move before tests for now. The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.
jbudz
added a commit
that referenced
this pull request
Nov 5, 2024
jbudz
added a commit
that referenced
this pull request
Nov 5, 2024
jbudz
added a commit
that referenced
this pull request
Nov 5, 2024
tylersmalley
added a commit
that referenced
this pull request
Feb 14, 2026
It's not an actual dependency of downstream steps, but was added more to provide as a cost cutting gate. However, there are times it delays downstream steps without any added value. Here's the provenance for `check_oas_snapshot` in the pull-request pipeline. ### 1. OAS snapshot capture first added to CI (inside "Checks") - [PR #183338](#183338) / commit [`975eeed255d0`](975eeed255d0) (May 30, 2024) — "[HTTP/OAS] Commit OAS snapshot" - Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the Checks step, not a standalone pipeline step yet). ### 2. Standalone "Check OAS Snapshot" step added to PR pipeline - [PR #196534](#196534) / commit [`2fbc843e0d69`](2fbc843e0d69) (Oct 17, 2024) — "[ci] Extract OAS check + add retry" - Motivation (from the PR summary): the capture step was flaky and was breaking Checks; they extracted it into its own heavy step (starts ES+Kibana) and added retries. - This is where it gets added as its own step in `.buildkite/pipelines/pull_request/base.yml`, running `.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`. ### 3. `depends_on: check_oas_snapshot` added across PR test suite pipelines - [PR #198452](#198452) / commit [`cbb211abe0cd`](cbb211abe0cd) (Nov 4, 2024) — "[ci] Run checks before tests" - This commit added `key: check_oas_snapshot` in `.buildkite/pipelines/pull_request/base.yml` and updated many PR suite pipeline YAMLs to depend on it (and on `checks`) before running. - Example change: `.buildkite/pipelines/pull_request/response_ops.yml` adds `- check_oas_snapshot` under `depends_on` in that commit. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
patrykkopycinski
pushed a commit
to patrykkopycinski/kibana
that referenced
this pull request
Feb 19, 2026
It's not an actual dependency of downstream steps, but was added more to provide as a cost cutting gate. However, there are times it delays downstream steps without any added value. Here's the provenance for `check_oas_snapshot` in the pull-request pipeline. ### 1. OAS snapshot capture first added to CI (inside "Checks") - [PR elastic#183338](elastic#183338) / commit [`975eeed255d0`](elastic@975eeed255d0) (May 30, 2024) — "[HTTP/OAS] Commit OAS snapshot" - Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the Checks step, not a standalone pipeline step yet). ### 2. Standalone "Check OAS Snapshot" step added to PR pipeline - [PR elastic#196534](elastic#196534) / commit [`2fbc843e0d69`](elastic@2fbc843e0d69) (Oct 17, 2024) — "[ci] Extract OAS check + add retry" - Motivation (from the PR summary): the capture step was flaky and was breaking Checks; they extracted it into its own heavy step (starts ES+Kibana) and added retries. - This is where it gets added as its own step in `.buildkite/pipelines/pull_request/base.yml`, running `.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`. ### 3. `depends_on: check_oas_snapshot` added across PR test suite pipelines - [PR elastic#198452](elastic#198452) / commit [`cbb211abe0cd`](elastic@cbb211abe0cd) (Nov 4, 2024) — "[ci] Run checks before tests" - This commit added `key: check_oas_snapshot` in `.buildkite/pipelines/pull_request/base.yml` and updated many PR suite pipeline YAMLs to depend on it (and on `checks`) before running. - Example change: `.buildkite/pipelines/pull_request/response_ops.yml` adds `- check_oas_snapshot` under `depends_on` in that commit. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
It's not an actual dependency of downstream steps, but was added more to provide as a cost cutting gate. However, there are times it delays downstream steps without any added value. Here's the provenance for `check_oas_snapshot` in the pull-request pipeline. ### 1. OAS snapshot capture first added to CI (inside "Checks") - [PR elastic#183338](elastic#183338) / commit [`975eeed255d0`](elastic@975eeed255d0) (May 30, 2024) — "[HTTP/OAS] Commit OAS snapshot" - Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the Checks step, not a standalone pipeline step yet). ### 2. Standalone "Check OAS Snapshot" step added to PR pipeline - [PR elastic#196534](elastic#196534) / commit [`2fbc843e0d69`](elastic@2fbc843e0d69) (Oct 17, 2024) — "[ci] Extract OAS check + add retry" - Motivation (from the PR summary): the capture step was flaky and was breaking Checks; they extracted it into its own heavy step (starts ES+Kibana) and added retries. - This is where it gets added as its own step in `.buildkite/pipelines/pull_request/base.yml`, running `.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`. ### 3. `depends_on: check_oas_snapshot` added across PR test suite pipelines - [PR elastic#198452](elastic#198452) / commit [`cbb211abe0cd`](elastic@cbb211abe0cd) (Nov 4, 2024) — "[ci] Run checks before tests" - This commit added `key: check_oas_snapshot` in `.buildkite/pipelines/pull_request/base.yml` and updated many PR suite pipeline YAMLs to depend on it (and on `checks`) before running. - Example change: `.buildkite/pipelines/pull_request/response_ops.yml` adds `- check_oas_snapshot` under `depends_on` in that commit. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be the last group to move before tests for now.
The intent has been to move steps that fit in the build window to run before tests start. Catching errors before parallel steps should help reduce the number of test runs with known issues.