Skip to content

[CI] Remove check_oas_snapshot as dependency#253156

Merged
tylersmalley merged 1 commit intoelastic:mainfrom
tylersmalley:rm-check_oas_snapshot-dep
Feb 14, 2026
Merged

[CI] Remove check_oas_snapshot as dependency#253156
tylersmalley merged 1 commit intoelastic:mainfrom
tylersmalley:rm-check_oas_snapshot-dep

Conversation

@tylersmalley
Copy link
Copy Markdown
Member

@tylersmalley tylersmalley commented Feb 14, 2026 •
edited by kibanamachine
Loading

It's not an actual dependency of downstream steps, but was added more to provide as a cost cutting gate. However, there are times it delays downstream steps without any added value.

Here's the provenance for check_oas_snapshot in the pull-request pipeline.

1. OAS snapshot capture first added to CI (inside "Checks")

  • PR #183338 / commit 975eeed255d0 (May 30, 2024) —
    "[HTTP/OAS] Commit OAS snapshot"
  • Added .buildkite/scripts/steps/capture_oas_snapshot.sh and wired it into .buildkite/scripts/steps/checks.sh (so it ran as part of the Checks step, not a
    standalone pipeline step yet).

2. Standalone "Check OAS Snapshot" step added to PR pipeline

  • PR #196534 / commit 2fbc843e0d69 (Oct 17, 2024) —
    "[ci] Extract OAS check + add retry"
  • Motivation (from the PR summary): the capture step was flaky and was breaking Checks; they extracted it into its own heavy step (starts ES+Kibana) and added
    retries.
  • This is where it gets added as its own step in .buildkite/pipelines/pull_request/base.yml, running
    .buildkite/scripts/steps/checks/capture_oas_snapshot.sh.

3. depends_on: check_oas_snapshot added across PR test suite pipelines

  • PR #198452 / commit cbb211abe0cd (Nov 4, 2024) —
    "[ci] Run checks before tests"
  • This commit added key: check_oas_snapshot in .buildkite/pipelines/pull_request/base.yml and updated many PR suite pipeline YAMLs to depend on it (and on
    checks) before running.
  • Example change: .buildkite/pipelines/pull_request/response_ops.yml adds - check_oas_snapshot under depends_on in that commit.

@tylersmalley
[CI] Remove check_oas_snapshot as dependency
7e45827 
It's not an actual dependency of downstream steps, but was added more to provide as a cost cutting gate. However, there are times it delays downstream steps without any added value.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@tylersmalley tylersmalley marked this pull request as ready for review February 14, 2026 01:55
@tylersmalley tylersmalley requested a review from a team as a code owner February 14, 2026 01:55
@tylersmalley tylersmalley added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Feb 14, 2026
mistic
mistic approved these changes Feb 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎉

@tylersmalley tylersmalley enabled auto-merge (squash) February 14, 2026 02:15
@tylersmalley tylersmalley merged commit d83e0ba into elastic:main Feb 14, 2026
25 checks passed
@tylersmalley tylersmalley deleted the rm-check_oas_snapshot-dep branch February 14, 2026 03:14
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 14, 2026

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/22010129876

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 14, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #3 / Rules Management - Prebuilt Rules (Common tests) @ess @serverless @skipInServerlessMKI Review installation using mocked prebuilt rule assets Pagination returns correct rules for a page specified in the request
  • [job] [logs] FTR Configs #21 / Serverless Common UI - Management Transform List "before all" hook for "renders the transform list"

Metrics [docs]

✅ unchanged

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 14, 2026

💔 All backports failed

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
❌ 9.2 Backport failed because of merge conflicts
❌ 9.3 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 253156

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 16, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 16, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 17, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 18, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Feb 19, 2026
@tylersmalley @patrykkopycinski
[CI] Remove check_oas_snapshot as dependency (elastic#253156)
cbaef00 
It's not an actual dependency of downstream steps, but was added more to
provide as a cost cutting gate. However, there are times it delays
downstream steps without any added value.

Here's the provenance for `check_oas_snapshot` in the pull-request
pipeline.

### 1. OAS snapshot capture first added to CI (inside "Checks")

- [PR elastic#183338](elastic#183338) / commit
[`975eeed255d0`](elastic@975eeed255d0)
(May 30, 2024) —
 "[HTTP/OAS] Commit OAS snapshot"
- Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it
into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the
Checks step, not a
standalone pipeline step yet).

### 2. Standalone "Check OAS Snapshot" step added to PR pipeline

- [PR elastic#196534](elastic#196534) / commit
[`2fbc843e0d69`](elastic@2fbc843e0d69)
(Oct 17, 2024) —
 "[ci] Extract OAS check + add retry"
- Motivation (from the PR summary): the capture step was flaky and was
breaking Checks; they extracted it into its own heavy step (starts
ES+Kibana) and added
retries.
- This is where it gets added as its own step in
`.buildkite/pipelines/pull_request/base.yml`, running
`.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`.

### 3. `depends_on: check_oas_snapshot` added across PR test suite
pipelines

- [PR elastic#198452](elastic#198452) / commit
[`cbb211abe0cd`](elastic@cbb211abe0cd)
(Nov 4, 2024) —
"[ci] Run checks before tests"
- This commit added `key: check_oas_snapshot` in
`.buildkite/pipelines/pull_request/base.yml` and updated many PR suite
pipeline YAMLs to depend on it (and on
`checks`) before running.
- Example change: `.buildkite/pipelines/pull_request/response_ops.yml`
adds `- check_oas_snapshot` under `depends_on` in that commit.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@tylersmalley @ersin-erdal
[CI] Remove check_oas_snapshot as dependency (elastic#253156)
d171e2b 
It's not an actual dependency of downstream steps, but was added more to
provide as a cost cutting gate. However, there are times it delays
downstream steps without any added value.

Here's the provenance for `check_oas_snapshot` in the pull-request
pipeline.

### 1. OAS snapshot capture first added to CI (inside "Checks")

- [PR elastic#183338](elastic#183338) / commit
[`975eeed255d0`](elastic@975eeed255d0)
(May 30, 2024) —
 "[HTTP/OAS] Commit OAS snapshot"
- Added `.buildkite/scripts/steps/capture_oas_snapshot.sh` and wired it
into `.buildkite/scripts/steps/checks.sh` (so it ran as part of the
Checks step, not a
standalone pipeline step yet).

### 2. Standalone "Check OAS Snapshot" step added to PR pipeline

- [PR elastic#196534](elastic#196534) / commit
[`2fbc843e0d69`](elastic@2fbc843e0d69)
(Oct 17, 2024) —
 "[ci] Extract OAS check + add retry"
- Motivation (from the PR summary): the capture step was flaky and was
breaking Checks; they extracted it into its own heavy step (starts
ES+Kibana) and added
retries.
- This is where it gets added as its own step in
`.buildkite/pipelines/pull_request/base.yml`, running
`.buildkite/scripts/steps/checks/capture_oas_snapshot.sh`.

### 3. `depends_on: check_oas_snapshot` added across PR test suite
pipelines

- [PR elastic#198452](elastic#198452) / commit
[`cbb211abe0cd`](elastic@cbb211abe0cd)
(Nov 4, 2024) —
"[ci] Run checks before tests"
- This commit added `key: check_oas_snapshot` in
`.buildkite/pipelines/pull_request/base.yml` and updated many PR suite
pipeline YAMLs to depend on it (and on
`checks`) before running.
- Example change: `.buildkite/pipelines/pull_request/response_ops.yml`
adds `- check_oas_snapshot` under `depends_on` in that commit.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 20, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 23, 2026

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 253156 locally
cc: @tylersmalley

@elastic elastic deleted a comment from kibanamachine Feb 27, 2026
@elastic elastic deleted a comment from kibanamachine Feb 27, 2026
@elastic elastic deleted a comment from kibanamachine Feb 27, 2026
@tylersmalley tylersmalley added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:all-open Backport to all branches that could still receive a release labels Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tylersmalley @kibanamachine @elasticmachine @mistic