[Security Solution] Removing cypress folder#197273
[Security Solution] Removing cypress folder#197273MadameSheema merged 9 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
wayneseymour
left a comment
There was a problem hiding this comment.
x-pack/test_serverless/tsconfig.json removal lgtm!
charlie-pichette
left a comment
There was a problem hiding this comment.
Thanks for doing this @MadameSheema!
|
@paul-tavares could you please take a look at this? It seems like you were the one who originally introduced these functionalities. From my perspective, it looks safe to remove, but I wanted to get your opinion before proceeding. Thanks! |
szwarckonrad
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing this!
| - x-pack/test/defend_workflows_cypress/serverless_config.base.ts | ||
| - x-pack/test/osquery_cypress/serverless_config.base.ts |
There was a problem hiding this comment.
Shouldn't base configs be placed in the section above?
There was a problem hiding this comment.
Looks like! Thanks for noticing :)
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.15, 8.16, 8.x |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
4 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Starting backport for target branches: 8.16, 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
## Summary Deleting the Cypress folder that was added in `test_serverless` as a POC. Currently is not used and this can create misunderstandings regarding ownership of it. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 86e6c74) # Conflicts: # .buildkite/pipelines/pull_request/security_solution/defend_workflows.yml # .github/CODEOWNERS
## Summary Deleting the Cypress folder that was added in `test_serverless` as a POC. Currently is not used and this can create misunderstandings regarding ownership of it. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 86e6c74) # Conflicts: # .buildkite/pipelines/pull_request/security_solution/defend_workflows.yml # .github/CODEOWNERS
> [!Warning] > `.github/CODEOWNERS` and `.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml` were updated as part of merge conflicts so would need a thorough review. # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution] Removing cypress folder (#197273)](#197273) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team: SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
> [!Warning] > `.github/CODEOWNERS` and `.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml` were updated as part of merge conflicts so would need a thorough review. # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Removing cypress folder (#197273)](#197273) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gloria Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport missing","v9.0.0","Team: SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security Solution] Removing cypress folder (#197273)\n\n## Summary\r\n\r\nDeleting the Cypress folder that was added in `test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can create misunderstandings regarding\r\nownership of it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Summary
Deleting the Cypress folder that was added in
test_serverlessas a POC.Currently is not used and this can create misunderstandings regarding ownership of it.