Skip to content

[Security Solution] Removing cypress folder#197273

Merged
MadameSheema merged 9 commits intoelastic:mainfrom
MadameSheema:deleting-folder
Oct 24, 2024
Merged

[Security Solution] Removing cypress folder#197273
MadameSheema merged 9 commits intoelastic:mainfrom
MadameSheema:deleting-folder

Conversation

@MadameSheema
Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema commented Oct 22, 2024

Summary

Deleting the Cypress folder that was added in test_serverless as a POC.

Currently is not used and this can create misunderstandings regarding ownership of it.

@MadameSheema MadameSheema added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-major v8.16.0 v8.17.0 labels Oct 22, 2024
@MadameSheema MadameSheema self-assigned this Oct 22, 2024
@MadameSheema MadameSheema requested review from a team as code owners October 22, 2024 15:10
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner October 22, 2024 15:25
Copy link
Copy Markdown
Contributor

@wayneseymour wayneseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x-pack/test_serverless/tsconfig.json removal lgtm!

Copy link
Copy Markdown
Contributor

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @MadameSheema!

@MadameSheema MadameSheema requested a review from a team as a code owner October 23, 2024 10:59
@MadameSheema MadameSheema requested a review from tomsonpl October 23, 2024 10:59
@tomsonpl
Copy link
Copy Markdown
Contributor

@paul-tavares could you please take a look at this? It seems like you were the one who originally introduced these functionalities. From my perspective, it looks safe to remove, but I wanted to get your opinion before proceeding. Thanks!

@tomsonpl tomsonpl requested review from paul-tavares and removed request for tomsonpl October 24, 2024 08:45
Copy link
Copy Markdown
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing this!

Comment on lines +11 to +12
- x-pack/test/defend_workflows_cypress/serverless_config.base.ts
- x-pack/test/osquery_cypress/serverless_config.base.ts
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't base configs be placed in the section above?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like! Thanks for noticing :)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @MadameSheema

@MadameSheema MadameSheema merged commit 86e6c74 into elastic:main Oct 24, 2024
@MadameSheema MadameSheema deleted the deleting-folder branch October 24, 2024 15:26
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11502485366

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 25, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 197273 locally

@ashokaditya ashokaditya added backport:version Backport to applied version labels and removed backport:prev-major labels Nov 7, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11718794852

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.16 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 197273

Questions ?

Please refer to the Backport tool documentation

@ashokaditya
Copy link
Copy Markdown
Member

💚 All backports created successfully

Status Branch Result
8.x
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request Nov 7, 2024
## Summary

Deleting the Cypress folder that was added in `test_serverless` as a
POC.

Currently is not used and this can create misunderstandings regarding
ownership of it.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 86e6c74)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
#	.github/CODEOWNERS
ashokaditya pushed a commit to ashokaditya/kibana that referenced this pull request Nov 7, 2024
## Summary

Deleting the Cypress folder that was added in `test_serverless` as a
POC.

Currently is not used and this can create misunderstandings regarding
ownership of it.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 86e6c74)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
#	.github/CODEOWNERS
ashokaditya added a commit that referenced this pull request Nov 7, 2024
> [!Warning]
> `.github/CODEOWNERS` and
`.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml`
were updated as part of merge conflicts so would need a thorough review.

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution] Removing cypress folder
(#197273)](#197273)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:
SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
ashokaditya added a commit that referenced this pull request Nov 7, 2024
> [!Warning]
> `.github/CODEOWNERS` and
`.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml`
were updated as part of merge conflicts so would need a thorough review.

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Solution] Removing cypress folder
(#197273)](#197273)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gloria
Hornero","email":"gloria.hornero@elastic.co"},"sourceCommit":{"committedDate":"2024-10-24T15:26:33Z","message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","v9.0.0","Team:
SecuritySolution","v8.16.0","backport:version","v8.17.0"],"number":197273,"url":"https://github.com/elastic/kibana/pull/197273","mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197273","number":197273,"mergeCommit":{"message":"[Security
Solution] Removing cypress folder (#197273)\n\n##
Summary\r\n\r\nDeleting the Cypress folder that was added in
`test_serverless` as a\r\nPOC.\r\n\r\nCurrently is not used and this can
create misunderstandings regarding\r\nownership of
it.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"86e6c74f7c39a512eaa43cc025434dc6a53d55f6"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Gloria Hornero <gloria.hornero@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants