Skip to content

[8.x] [Security Solution] Removing cypress folder (#197273)#199260

Merged
ashokaditya merged 2 commits intoelastic:8.xfrom
ashokaditya:backport/8.x/pr-197273
Nov 7, 2024
Merged

[8.x] [Security Solution] Removing cypress folder (#197273)#199260
ashokaditya merged 2 commits intoelastic:8.xfrom
ashokaditya:backport/8.x/pr-197273

Conversation

@ashokaditya
Copy link
Copy Markdown
Member

@ashokaditya ashokaditya commented Nov 7, 2024

Warning

.github/CODEOWNERS and .buildkite/pipelines/pull_request/security_solution/defend_workflows.yml were updated as part of merge conflicts so would need a thorough review.

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Deleting the Cypress folder that was added in `test_serverless` as a
POC.

Currently is not used and this can create misunderstandings regarding
ownership of it.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 86e6c74)

# Conflicts:
#	.buildkite/pipelines/pull_request/security_solution/defend_workflows.yml
#	.github/CODEOWNERS
@ashokaditya ashokaditya added the backport This PR is a backport of another PR label Nov 7, 2024
@ashokaditya ashokaditya enabled auto-merge (squash) November 7, 2024 08:13
Copy link
Copy Markdown
Contributor

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ashokaditya ashokaditya merged commit feab4ef into elastic:8.x Nov 7, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

@jbudz
Copy link
Copy Markdown
Contributor

jbudz commented Nov 7, 2024

Hi all, please make sure to double review backports when there's merge conflicts.

This added CODEOWNERs and a group of serverless tests to 8.x - reverted with 2c4f352 + ed448dd.

@ashokaditya
Copy link
Copy Markdown
Member Author

Thanks @jbudz. We realized it right after the auto-merge. Thanks for fixing it qucikly

@ashokaditya ashokaditya deleted the backport/8.x/pr-197273 branch November 7, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants