[8.x] [ci] Extract OAS check + add retry (#196534)#196799
Merged
delanni merged 4 commits intoelastic:8.xfrom Oct 25, 2024
Merged
[8.x] [ci] Extract OAS check + add retry (#196534)#196799delanni merged 4 commits intoelastic:8.xfrom
delanni merged 4 commits intoelastic:8.xfrom
Conversation
## Summary In the past months, the capture OAS snapshot step has been quite flaky, breaking the `Checks` step, and thus breaking the `on-merge` jobs. This PR extracts the check to its own step and adds retries. The separate step is ideal because it is quite heavy compared to the other checks (we fire up ES + Kibana for the OAS snapshot). Also, this PR removes the `Checks` step altogether from the kibana-chrome-forward-testing pipeline, as the Chrome versions used do not affect that aspect. This test run includes a retry within the Capture OAS Snapshot step: https://buildkite.com/elastic/kibana-pull-request/builds/243187#01929612-dac7-4584-b440-120ea3fea7ea (cherry picked from commit 2fbc843) # Conflicts: # .buildkite/pipelines/chrome_forward_testing.yml
jbudz
reviewed
Oct 18, 2024
| @@ -0,0 +1,355 @@ | |||
| env: | |||
Member
Author
There was a problem hiding this comment.
You're right, it wasn't.
I believe it appeared through conflict resolution. Maybe keeping the missing file would have been the right resolution, this pipeline file won't be used in non-main branches.
However, if 8.x and main diverge significantly, we might want to run the forward testing for the two branches separately. 8.x is going to live for a while, no? What do you think?
Contributor
💚 Build Succeeded
Metrics [docs]
History
|
jbudz
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation