Skip to content

[Graph] Escape backslash characters in the graph encode functions#196239

Merged
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:graph/fix_code_scanning_alert_71
Oct 17, 2024
Merged

[Graph] Escape backslash characters in the graph encode functions#196239
mbondyra merged 2 commits intoelastic:mainfrom
mbondyra:graph/fix_code_scanning_alert_71

Conversation

@mbondyra
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra commented Oct 15, 2024

Summary

Escape backslash characters in the graph encode functions.

@mbondyra mbondyra added Feature:Graph Graph application feature Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// backport:skip This PR does not require backporting backport:prev-major labels Oct 15, 2024
@mbondyra mbondyra requested a review from a team as a code owner October 15, 2024 07:58
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-graph (Feature:Graph)

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This PR does not require backporting labels Oct 15, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
graph 413.0KB 413.0KB +22.0B

@mbondyra mbondyra added backport:all-open Backport to all branches that could still receive a release and removed backport:prev-major labels Oct 17, 2024
@mbondyra mbondyra merged commit 57c4b40 into elastic:main Oct 17, 2024
@mbondyra mbondyra deleted the graph/fix_code_scanning_alert_71 branch October 17, 2024 12:08
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11384603593

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
…astic#196239)

## Summary

Escape backslash characters in the graph encode functions.

(cherry picked from commit 57c4b40)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
…astic#196239)

## Summary

Escape backslash characters in the graph encode functions.

(cherry picked from commit 57c4b40)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
…astic#196239)

## Summary

Escape backslash characters in the graph encode functions.

(cherry picked from commit 57c4b40)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 17, 2024
…astic#196239)

## Summary

Escape backslash characters in the graph encode functions.

(cherry picked from commit 57c4b40)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
7.17
8.15
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 17, 2024
…ns (#196239) (#196684)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Graph] Escape backslash characters in the graph encode functions
(#196239)](#196239)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T12:08:23Z","message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","Team:Visualizations","release_note:skip","v9.0.0","backport:all-open"],"title":"[Graph]
Escape backslash characters in the graph encode
functions","number":196239,"url":"https://github.com/elastic/kibana/pull/196239","mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196239","number":196239,"mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Oct 17, 2024
…ons (#196239) (#196682)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Graph] Escape backslash characters in the graph encode functions
(#196239)](#196239)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T12:08:23Z","message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","Team:Visualizations","release_note:skip","v9.0.0","backport:all-open"],"title":"[Graph]
Escape backslash characters in the graph encode
functions","number":196239,"url":"https://github.com/elastic/kibana/pull/196239","mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196239","number":196239,"mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Oct 17, 2024

This PR didn't make it into the latest BC of v8.15.3. Updating the labels.

@mistic mistic added v8.15.4 and removed v8.15.3 labels Oct 17, 2024
kibanamachine added a commit that referenced this pull request Oct 18, 2024
…ons (#196239) (#196683)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Graph] Escape backslash characters in the graph encode functions
(#196239)](#196239)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T12:08:23Z","message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","Team:Visualizations","release_note:skip","v9.0.0","backport:all-open"],"title":"[Graph]
Escape backslash characters in the graph encode
functions","number":196239,"url":"https://github.com/elastic/kibana/pull/196239","mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196239","number":196239,"mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Oct 18, 2024
…ons (#196239) (#196681)

# Backport

This will backport the following commits from `main` to `7.17`:
- [[Graph] Escape backslash characters in the graph encode functions
(#196239)](#196239)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marta
Bondyra","email":"4283304+mbondyra@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T12:08:23Z","message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Graph","Team:Visualizations","release_note:skip","v9.0.0","backport:all-open"],"title":"[Graph]
Escape backslash characters in the graph encode
functions","number":196239,"url":"https://github.com/elastic/kibana/pull/196239","mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode
functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196239","number":196239,"mergeCommit":{"message":"[Graph]
Escape backslash characters in the graph encode functions
(#196239)\n\n## Summary\r\n\r\nEscape backslash characters in the graph
encode functions.","sha":"57c4b40270ff584ab8bc1859e1097ceb14171be0"}}]}]
BACKPORT-->

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Oct 22, 2024

This PR was not included in the latest BC for v7.17.25. Updating the labels.

@mistic mistic added v7.17.26 and removed v7.17.25 labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release Feature:Graph Graph application feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.17.26 v8.15.4 v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants