[Telemetry] Fetch snapshot: allow specifying the version via querystring#164670
Merged
afharo merged 1 commit intoelastic:mainfrom Aug 24, 2023
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
pgayvallet
approved these changes
Aug 24, 2023
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM
If we're planning on needing this on multiple APIs, I wonder if the better solution wouldn't be for the dev console to allow passing the version header somehow for kbn: requests.
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: cc @afharo |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 24, 2023
…ing (elastic#164670) (cherry picked from commit 57a5824)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2023
…uerystring (#164670) (#164684) # Backport This will backport the following commits from `main` to `8.10`: - [[Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)](#164670) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-08-24T10:13:38Z","message":"[Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)","sha":"57a58240d3c784d5bd9fac835f59cce39b923a6d","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","technical debt","release_note:skip","backport:prev-minor","v8.11.0"],"number":164670,"url":"https://github.com/elastic/kibana/pull/164670","mergeCommit":{"message":"[Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)","sha":"57a58240d3c784d5bd9fac835f59cce39b923a6d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164670","number":164670,"mergeCommit":{"message":"[Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)","sha":"57a58240d3c784d5bd9fac835f59cce39b923a6d"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
jloleysens
added a commit
that referenced
this pull request
Aug 24, 2023
* main: (3152 commits) [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682) [SavedObjects] Create serverless roots for jest integration tests (#164157) Create upselling package and implement EntityAnalytics serverless upselling (#164136) [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673) [IndexManagement] Use internal base path for API (#164665) [Profiling] removing ~ symbol (#164595) [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670) [Cases] Show warning when all cases table reaches 10k cases message (#164323) [ML] Removing token list from text expansion model testing (#164560) [Fleet] Add secrets package API integration test (#164583) [Fleet] Fix security solution tag id (#164582) [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908) [api-docs] 2023-08-24 Daily api_docs build (#164658) [APM] Cleanup alerting api tests (#164438) Upgrade EUI to 87.2.0 (#164385) [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485) [Fleet] Fix flaky unit test for the details page (#164641) [Security Solution] update codeowner for serverless security subdir (#164640) [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382) [Discover] Removing large string truncation from doc viewer (#164236) ...
This was referenced Oct 1, 2023
Contributor
@pgayvallet I agree. Looks like more teams need to specify the version via querystring. Do you know which team is responsible for solving this issue globally? I am using the transform api on Dev tools and since it is versioned I had to locally change the transform register route code to be able to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We tend to use the Telemetry Snapshot endpoint during development to test our collectors and to understand the behavior of Kibana.
The easiest way to interact with it is the Dev Console. However, it does not allow specifying any headers. Let's allow specifying the version through the query parameter for this endpoint:
For maintainers