Skip to content

[Cases] Show warning when all cases table reaches 10k cases message#164323

Merged
js-jankisalvi merged 13 commits intoelastic:mainfrom
js-jankisalvi:10k-cases-message
Aug 24, 2023
Merged

[Cases] Show warning when all cases table reaches 10k cases message#164323
js-jankisalvi merged 13 commits intoelastic:mainfrom
js-jankisalvi:10k-cases-message

Conversation

@js-jankisalvi
Copy link
Copy Markdown
Contributor

@js-jankisalvi js-jankisalvi commented Aug 21, 2023

Summary

Fixes #154625

Note: Cases max limit is set as 40 for below recording:

10k.cases.mov

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release Note:

Show a warning message to inform user that navigating after the 10Kth case is not possible.

@js-jankisalvi js-jankisalvi added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Feature:Cases Cases feature v8.11.0 labels Aug 21, 2023
@js-jankisalvi js-jankisalvi self-assigned this Aug 21, 2023
@js-jankisalvi js-jankisalvi added the release_note:skip Skip the PR/issue when compiling release notes label Aug 23, 2023
@js-jankisalvi js-jankisalvi marked this pull request as ready for review August 23, 2023 12:18
@js-jankisalvi js-jankisalvi requested a review from a team as a code owner August 23, 2023 12:18
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

Copy link
Copy Markdown
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works fine.

I am just not sure about two things:

  • do we want to display totalItems or MAX_DOCS in the error message?
  • when do we display the message

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 422.0KB 423.1KB +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cases 151.5KB 152.0KB +510.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

@js-jankisalvi js-jankisalvi added release_note:enhancement and removed release_note:skip Skip the PR/issue when compiling release notes labels Aug 24, 2023
@js-jankisalvi js-jankisalvi merged commit c00fc42 into elastic:main Aug 24, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Aug 24, 2023
jloleysens added a commit that referenced this pull request Aug 24, 2023
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
@js-jankisalvi js-jankisalvi deleted the 10k-cases-message branch February 19, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Cases Cases feature release_note:enhancement Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cases] Cannot navigate to more that 10K Cases

5 participants