Skip to content

[Profiling] removing ~ symbol#164595

Merged
cauemarcondes merged 1 commit intoelastic:mainfrom
cauemarcondes:profiling-remove-round-values
Aug 24, 2023
Merged

[Profiling] removing ~ symbol#164595
cauemarcondes merged 1 commit intoelastic:mainfrom
cauemarcondes:profiling-remove-round-values

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Aug 23, 2023

Before:
Screenshot 2023-08-23 at 15 03 38

After
Screenshot 2023-08-23 at 15 04 11

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes v8.10.0 labels Aug 23, 2023
@cauemarcondes cauemarcondes requested a review from a team as a code owner August 23, 2023 14:10
@ghost
Copy link
Copy Markdown

ghost commented Aug 23, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Copy Markdown
Contributor

@rockdaboot rockdaboot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Connectors "after all" hook in "Connectors"
  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group2/config_non_dedicated_task_runner.ts / alerting api integration security and spaces enabled - Group 2 Connectors "before all" hook in "Connectors"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
profiling 331.2KB 330.8KB -355.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit ad55946 into elastic:main Aug 24, 2023
@cauemarcondes cauemarcondes deleted the profiling-remove-round-values branch August 24, 2023 10:15
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2023
kibanamachine added a commit that referenced this pull request Aug 24, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [[Profiling] removing ~ symbol
(#164595)](#164595)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T10:15:32Z","message":"[Profiling]
removing ~ symbol (#164595)\n\nBefore:\r\n![Screenshot 2023-08-23 at 15
03\r\n38](https://github.com/elastic/kibana/assets/55978943/cd18f0a4-54b9-4dc6-a7d3-780189bf8e30)\r\n\r\nAfter\r\n![Screenshot
2023-08-23 at 15
04\r\n11](https://github.com/elastic/kibana/assets/55978943/bb8bbbec-ee35-446e-8ec8-865fe9d1b831)","sha":"ad55946c1275d4ce2bd8cc453580acf73bbc17bf","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.10.0","v8.11.0"],"number":164595,"url":"https://github.com/elastic/kibana/pull/164595","mergeCommit":{"message":"[Profiling]
removing ~ symbol (#164595)\n\nBefore:\r\n![Screenshot 2023-08-23 at 15
03\r\n38](https://github.com/elastic/kibana/assets/55978943/cd18f0a4-54b9-4dc6-a7d3-780189bf8e30)\r\n\r\nAfter\r\n![Screenshot
2023-08-23 at 15
04\r\n11](https://github.com/elastic/kibana/assets/55978943/bb8bbbec-ee35-446e-8ec8-865fe9d1b831)","sha":"ad55946c1275d4ce2bd8cc453580acf73bbc17bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164595","number":164595,"mergeCommit":{"message":"[Profiling]
removing ~ symbol (#164595)\n\nBefore:\r\n![Screenshot 2023-08-23 at 15
03\r\n38](https://github.com/elastic/kibana/assets/55978943/cd18f0a4-54b9-4dc6-a7d3-780189bf8e30)\r\n\r\nAfter\r\n![Screenshot
2023-08-23 at 15
04\r\n11](https://github.com/elastic/kibana/assets/55978943/bb8bbbec-ee35-446e-8ec8-865fe9d1b831)","sha":"ad55946c1275d4ce2bd8cc453580acf73bbc17bf"}}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Aug 24, 2023
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants