Skip to content

[IndexManagement] Use internal base path for API#164665

Merged
dej611 merged 2 commits intomainfrom
fix/indexmanagement_service_api_url
Aug 24, 2023
Merged

[IndexManagement] Use internal base path for API#164665
dej611 merged 2 commits intomainfrom
fix/indexmanagement_service_api_url

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Aug 24, 2023

Summary

The current API is returning 404 as the correct path is internal. This PR fixes this problem.

@dej611 dej611 added release_note:fix Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// labels Aug 24, 2023
@dej611 dej611 requested a review from a team as a code owner August 24, 2023 07:31
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611 dej611 merged commit 86224d4 into main Aug 24, 2023
@dej611 dej611 deleted the fix/indexmanagement_service_api_url branch August 24, 2023 10:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 24, 2023
## Summary

The current API is returning 404 as the correct path is internal. This
PR fixes this problem.

(cherry picked from commit 86224d4)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 24, 2023
…64685)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[IndexManagement] Use internal base path for API
(#164665)](#164665)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T10:30:21Z","message":"[IndexManagement]
Use internal base path for API (#164665)\n\n## Summary\r\n\r\nThe
current API is returning 404 as the correct path is internal. This\r\nPR
fixes this
problem.","sha":"86224d4cf60bfe2ae84c9b55bfaedc1476213a99","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Feature:Index
Management","Team:Deployment
Management","v8.10.0","v8.11.0"],"number":164665,"url":"https://github.com/elastic/kibana/pull/164665","mergeCommit":{"message":"[IndexManagement]
Use internal base path for API (#164665)\n\n## Summary\r\n\r\nThe
current API is returning 404 as the correct path is internal. This\r\nPR
fixes this
problem.","sha":"86224d4cf60bfe2ae84c9b55bfaedc1476213a99"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164665","number":164665,"mergeCommit":{"message":"[IndexManagement]
Use internal base path for API (#164665)\n\n## Summary\r\n\r\nThe
current API is returning 404 as the correct path is internal. This\r\nPR
fixes this
problem.","sha":"86224d4cf60bfe2ae84c9b55bfaedc1476213a99"}}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
jloleysens added a commit that referenced this pull request Aug 24, 2023
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Index Management Index and index templates UI release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v8.10.0 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants