[Fleet] Add secrets package API integration test#164583
Merged
jillguyonnet merged 2 commits intoelastic:mainfrom Aug 24, 2023
Merged
[Fleet] Add secrets package API integration test#164583jillguyonnet merged 2 commits intoelastic:mainfrom
jillguyonnet merged 2 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
juliaElastic
approved these changes
Aug 23, 2023
Contributor
juliaElastic
left a comment
There was a problem hiding this comment.
Thanks for the test, LGTM!
Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
hop-dev
approved these changes
Aug 23, 2023
Contributor
hop-dev
left a comment
There was a problem hiding this comment.
Nice, really glad we have this test 👍
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 24, 2023
## Summary Closes elastic#162045 This PR adds an API integration test for the following scenario: - Given an integration with some non secret (plain text) vars that become secret in a newer version; - When Fleet has an agent policy with this integration and upgrades from the old to the newer version; - Then the vars that have become secrets should correctly be stored as secret values. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com> (cherry picked from commit 766ff8f)
kibanamachine
added a commit
that referenced
this pull request
Aug 24, 2023
…64666) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Add secrets package API integration test (#164583)](#164583) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jill Guyonnet","email":"jill.guyonnet@elastic.co"},"sourceCommit":{"committedDate":"2023-08-24T07:37:34Z","message":"[Fleet] Add secrets package API integration test (#164583)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/162045\r\n\r\nThis PR adds an API integration test for the following scenario:\r\n- Given an integration with some non secret (plain text) vars that\r\nbecome secret in a newer version;\r\n- When Fleet has an agent policy with this integration and upgrades from\r\nthe old to the newer version;\r\n- Then the vars that have become secrets should correctly be stored as\r\nsecret values.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"766ff8fa614d6b62b750c0eef9c1d129b2187e4f","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.10.0","v8.11.0"],"number":164583,"url":"https://github.com/elastic/kibana/pull/164583","mergeCommit":{"message":"[Fleet] Add secrets package API integration test (#164583)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/162045\r\n\r\nThis PR adds an API integration test for the following scenario:\r\n- Given an integration with some non secret (plain text) vars that\r\nbecome secret in a newer version;\r\n- When Fleet has an agent policy with this integration and upgrades from\r\nthe old to the newer version;\r\n- Then the vars that have become secrets should correctly be stored as\r\nsecret values.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"766ff8fa614d6b62b750c0eef9c1d129b2187e4f"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164583","number":164583,"mergeCommit":{"message":"[Fleet] Add secrets package API integration test (#164583)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/162045\r\n\r\nThis PR adds an API integration test for the following scenario:\r\n- Given an integration with some non secret (plain text) vars that\r\nbecome secret in a newer version;\r\n- When Fleet has an agent policy with this integration and upgrades from\r\nthe old to the newer version;\r\n- Then the vars that have become secrets should correctly be stored as\r\nsecret values.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>","sha":"766ff8fa614d6b62b750c0eef9c1d129b2187e4f"}}]}] BACKPORT--> Co-authored-by: Jill Guyonnet <jill.guyonnet@elastic.co>
jloleysens
added a commit
that referenced
this pull request
Aug 24, 2023
* main: (3152 commits) [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682) [SavedObjects] Create serverless roots for jest integration tests (#164157) Create upselling package and implement EntityAnalytics serverless upselling (#164136) [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673) [IndexManagement] Use internal base path for API (#164665) [Profiling] removing ~ symbol (#164595) [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670) [Cases] Show warning when all cases table reaches 10k cases message (#164323) [ML] Removing token list from text expansion model testing (#164560) [Fleet] Add secrets package API integration test (#164583) [Fleet] Fix security solution tag id (#164582) [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908) [api-docs] 2023-08-24 Daily api_docs build (#164658) [APM] Cleanup alerting api tests (#164438) Upgrade EUI to 87.2.0 (#164385) [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485) [Fleet] Fix flaky unit test for the details page (#164641) [Security Solution] update codeowner for serverless security subdir (#164640) [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382) [Discover] Removing large string truncation from doc viewer (#164236) ...
This was referenced Oct 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #162045
This PR adds an API integration test for the following scenario:
Checklist