Create upselling package and implement EntityAnalytics serverless upselling by machadoum · Pull Request #164136 · elastic/kibana

machadoum · 2023-08-17T07:59:33Z

UX: https://github.com/elastic/security-team/issues/7310

Summary

It creates an Upselling package to share the service and components between ESS and Serverless plugins
It implements upselling for entity analytics on serverless by replicating the ESS approach

ESS

Serverless

We are not displaying the upgrade button because we still don't know how to link to the cloud settings page.

elasticmachine · 2023-08-17T13:31:35Z

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

elasticmachine · 2023-08-17T13:31:37Z

Pinging @elastic/security-solution (Team: SecuritySolution)

x-pack/packages/security-solution/upselling/pages/entity_analytics.tsx

stephmilovic · 2023-08-17T17:28:32Z

x-pack/packages/security-solution/upselling/pages/translations.ts

We should not use the word "subscription" in serverless

Suggested change

defaultMessage: 'Entity Analytics is available with {requiredProduct} subscriptions',

defaultMessage: 'Update your project features with {requiredProduct}',

It is aligned with the design on this ticket: https://github.com/elastic/security-team/issues/7310
@SourinPaul @craig-abbott Could you please consider this comment and provide a new copy?

I would suggest Entity risk scoring is available with SIEM Complete tier but I am unsure if the user would understand.

stephmilovic

LGTM, tested locally and all works as expected. Only comments are to update any serverless language to not use the word "subscription". Nice work @machadoum

SourinPaul · 2023-08-23T18:32:46Z

Only comments are to update any serverless language to not use the word "subscription". Nice work @machadoum

@machadoum Since you need to close this, I recommend the following:

Entity risk scoring capability is available in our SIEM Complete license tier.....

Btw, I noticed that PLU worksheet refers to SIEM Essentials/ Complete as Security Essentials/ Complete.

gergoabraham

defend workflows related changes LGTM 🚀

…ESS and Serverless plugins

dasansol92

Changes under /management LGTM!

…fix'

kibana-ci · 2023-08-24T11:18:20Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 08378bb

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolutionServerless`	410	413	+3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`securitySolution`	129	109	-20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	15.7MB	15.7MB	+6.2KB
`securitySolutionEss`	42.0KB	42.4KB	+409.0B
`securitySolutionServerless`	249.3KB	266.2KB	+16.9KB
total			+23.4KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/security-solution-upselling`	-	1	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolutionEss`	8.0KB	8.2KB	+142.0B
`securitySolutionServerless`	38.0KB	38.4KB	+330.0B
total			+472.0B

Unknown metric groups

API count

id	before	after	diff
`securitySolution`	195	175	-20

async chunk count

id	before	after	diff
`securitySolutionServerless`	35	36	+1

ESLint disabled line counts

id	before	after	diff
`@kbn/security-solution-upselling`	-	1	+1
`securitySolutionEss`	6	5	-1
`securitySolutionServerless`	34	32	-2
total			-2

miscellaneous assets size

id	before	after	diff
`securitySolutionServerless`	740.5KB	2.9MB	⚠️ +2.2MB

Total ESLint disabled count

id	before	after	diff
`@kbn/security-solution-upselling`	-	1	+1
`securitySolutionEss`	6	5	-1
`securitySolutionServerless`	34	32	-2
total			-2

History

💔 Build #153037 failed cd720673b0c91122b5be51642b00b22c71e32972
💔 Build #153033 failed 7f5353dafba6eb6fe2b90b144a7413d13767affd
💛 Build #151866 was flaky d7b4c40ea3e5f48953d04c2097d351b471494df0
💛 Build #151751 was flaky 7e948de8ee672f4cf25a9d1c55899c187dbfaf96
💚 Build #151481 succeeded 8162fb7288f0c255bd8a9f5d106cf9949d549d2a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

* main: (3152 commits) [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682) [SavedObjects] Create serverless roots for jest integration tests (#164157) Create upselling package and implement EntityAnalytics serverless upselling (#164136) [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673) [IndexManagement] Use internal base path for API (#164665) [Profiling] removing ~ symbol (#164595) [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670) [Cases] Show warning when all cases table reaches 10k cases message (#164323) [ML] Removing token list from text expansion model testing (#164560) [Fleet] Add secrets package API integration test (#164583) [Fleet] Fix security solution tag id (#164582) [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908) [api-docs] 2023-08-24 Daily api_docs build (#164658) [APM] Cleanup alerting api tests (#164438) Upgrade EUI to 87.2.0 (#164385) [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485) [Fleet] Fix flaky unit test for the details page (#164641) [Security Solution] update codeowner for serverless security subdir (#164640) [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382) [Discover] Removing large string truncation from doc viewer (#164236) ...

machadoum changed the title ~~Create Upselling package to share the service and components between …~~ Create Upselling package and implement EntityAnalytics serverless upselling Aug 17, 2023

machadoum force-pushed the siem-explore-entity-analytics-plg branch 2 times, most recently from bc9f753 to 661fa4d Compare August 17, 2023 11:08

machadoum self-assigned this Aug 17, 2023

machadoum added Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore release_note:skip Skip the PR/issue when compiling release notes labels Aug 17, 2023

machadoum changed the title ~~Create Upselling package and implement EntityAnalytics serverless upselling~~ Create upselling package and implement EntityAnalytics serverless upselling Aug 17, 2023

machadoum marked this pull request as ready for review August 17, 2023 13:31

machadoum requested review from a team as code owners August 17, 2023 13:31

machadoum requested review from dasansol92 and gergoabraham August 17, 2023 13:31

stephmilovic reviewed Aug 17, 2023

View reviewed changes

x-pack/packages/security-solution/upselling/pages/entity_analytics.tsx Outdated Show resolved Hide resolved

stephmilovic reviewed Aug 17, 2023

View reviewed changes

stephmilovic approved these changes Aug 17, 2023

View reviewed changes

machadoum force-pushed the siem-explore-entity-analytics-plg branch 2 times, most recently from 7e948de to df25491 Compare August 21, 2023 12:26

machadoum force-pushed the siem-explore-entity-analytics-plg branch from d7b4c40 to 68ed0ce Compare August 24, 2023 07:16

machadoum enabled auto-merge (squash) August 24, 2023 07:16

gergoabraham approved these changes Aug 24, 2023

View reviewed changes

machadoum added 4 commits August 24, 2023 11:50

Create Upselling package to share the service and components between …

c96a7dc

…ESS and Serverless plugins

Update logic to hide risk score tabs when the capability is disabled

90db56a

Entity analytics link required capability

d661ac8

Fix CI

51aa729

machadoum added 5 commits August 24, 2023 11:50

Code review improvements

155594d

Add unit tests

51b7de2

Update upgrade product message

549902f

Update upselling service import to use package

5276ffb

Fix failing test

f5282ef

machadoum force-pushed the siem-explore-entity-analytics-plg branch from cd72067 to f5282ef Compare August 24, 2023 09:50

dasansol92 approved these changes Aug 24, 2023

View reviewed changes

kibanamachine added 2 commits August 24, 2023 09:56

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

a99b3fb

…fix'

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

08378bb

machadoum merged commit 7564479 into elastic:main Aug 24, 2023

kibanamachine added v8.11.0 backport:skip This PR does not require backporting labels Aug 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create upselling package and implement EntityAnalytics serverless upselling#164136

Create upselling package and implement EntityAnalytics serverless upselling#164136
machadoum merged 11 commits intoelastic:mainfrom
machadoum:siem-explore-entity-analytics-plg

machadoum commented Aug 17, 2023 •

edited

Loading

Uh oh!

elasticmachine commented Aug 17, 2023

Uh oh!

elasticmachine commented Aug 17, 2023

Uh oh!

Uh oh!

stephmilovic Aug 17, 2023

Uh oh!

machadoum Aug 21, 2023

Uh oh!

stephmilovic left a comment

Uh oh!

SourinPaul commented Aug 23, 2023

Uh oh!

gergoabraham left a comment

Uh oh!

dasansol92 left a comment

Uh oh!

kibana-ci commented Aug 24, 2023

API count

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	defaultMessage: 'Entity Analytics is available with {requiredProduct} subscriptions',
	defaultMessage: 'Update your project features with {requiredProduct}',

Conversation

machadoum commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Aug 17, 2023

Uh oh!

elasticmachine commented Aug 17, 2023

Uh oh!

Uh oh!

stephmilovic Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

machadoum Aug 21, 2023

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

SourinPaul commented Aug 23, 2023

Uh oh!

gergoabraham left a comment

Choose a reason for hiding this comment

Uh oh!

dasansol92 left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Aug 24, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

miscellaneous assets size

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

machadoum commented Aug 17, 2023 •

edited

Loading