Skip to content

[Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule#163908

Merged
maximpn merged 7 commits intoelastic:mainfrom
gitstart:ELS-180
Aug 24, 2023
Merged

[Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule#163908
maximpn merged 7 commits intoelastic:mainfrom
gitstart:ELS-180

Conversation

@gitstart
Copy link
Copy Markdown
Contributor

@gitstart gitstart commented Aug 15, 2023 •
edited
Loading

What does this PR do?

  • It fixes the count on the duplicate modal when duplicating an individual rule.

Issue References

Fixes #162035

Video/Screenshot Demo

Steps to reproduce & Fix:

https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

@gitstart
feat: [Security Solution] Modal says duplicating 0 rules when you d…
f852439 
…uplicate an individual rule

Co-authored-by: Klinger Matheus <klinger.matheus@gitstart.dev>
Co-authored-by: gitstart_bot <gitstart_bot@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 15, 2023

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@gitstart gitstart changed the title ELS-180 - [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule Aug 15, 2023
@gitstart gitstart marked this pull request as ready for review August 15, 2023 13:07
@gitstart gitstart requested a review from a team as a code owner August 15, 2023 13:07
@gitstart gitstart requested a review from maximpn August 15, 2023 13:07
@banderror banderror added bug Fixes for quality problems that affect the customer experience Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team labels Aug 16, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 16, 2023

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 16, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

maximpn
maximpn approved these changes Aug 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@maximpn maximpn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gitstart for the contribution! The fix looks good to me. We ideally need to have a test for this.

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 16, 2023

buildkite test this

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 16, 2023 •
edited
Loading

@elasticmachine merge upstream

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 21, 2023

@elasticmachine merge upstream

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 21, 2023

buildkite test this

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 21, 2023

@elasticmachine run elasticsearch-ci/docs

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 21, 2023

@elasticmachine merge upstream

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 21, 2023

buildkite test this

@elasticmachine run elasticsearch-ci/docs

@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 22, 2023

@elasticmachine merge upstream

buildkite test this

@elasticmachine run elasticsearch-ci/docs

1 similar comment
@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 23, 2023

@elasticmachine merge upstream

buildkite test this

@elasticmachine run elasticsearch-ci/docs

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 23, 2023

@elasticmachine merge upstream

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 23, 2023

buildkite test this

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 23, 2023

@elasticmachine run elasticsearch-ci/docs

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Aug 23, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.7MB 15.7MB +12.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maximpn maximpn merged commit 59f2058 into elastic:main Aug 24, 2023
@banderror banderror mentioned this pull request Aug 24, 2023
Merged
banderror pushed a commit to banderror/kibana that referenced this pull request Aug 24, 2023
@gitstart
[Security Solution] Modal says "duplicating 0 rules" when you duplica…
772c109 
…te an individual rule (elastic#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.

 ## Issue References
Fixes elastic#162035

 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___

 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

(cherry picked from commit 59f2058)
@banderror banderror mentioned this pull request Aug 24, 2023
Merged
@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 24, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.10
✅ 8.9

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@banderror
Copy link
Copy Markdown
Contributor

banderror commented Aug 24, 2023

@maximpn FYI for community PRs we need to create backports manually. Doing it for this one.

banderror pushed a commit to banderror/kibana that referenced this pull request Aug 24, 2023
@gitstart
[Security Solution] Modal says "duplicating 0 rules" when you duplica…
955cbd6 
…te an individual rule (elastic#163908)

 ## What does this PR do?
 * It fixes the count on the duplicate modal when duplicating an individual rule.

 ## Issue References
Fixes elastic#162035

 ## Video/Screenshot Demo
 ##### Steps to reproduce & Fix:
https://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9

___

 This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

(cherry picked from commit 59f2058)
jloleysens added a commit that referenced this pull request Aug 24, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
e582640 
* main: (3152 commits)
  [Security Solution][Detection Engine] fixes 410 error on index legacy template call (#164682)
  [SavedObjects] Create serverless roots for jest integration tests (#164157)
  Create upselling package and implement EntityAnalytics serverless upselling (#164136)
  [Fleet] Change 'Out-of-date' to 'Outdated policy' in agent list table (#164673)
  [IndexManagement] Use internal base path for API (#164665)
  [Profiling] removing ~ symbol (#164595)
  [Telemetry] Fetch snapshot: allow specifying the version via querystring (#164670)
  [Cases] Show warning when all cases table reaches 10k cases message (#164323)
  [ML] Removing token list from text expansion model testing (#164560)
  [Fleet] Add secrets package API integration test (#164583)
  [Fleet] Fix security solution tag id (#164582)
  [Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule (#163908)
  [api-docs] 2023-08-24 Daily api_docs build (#164658)
  [APM] Cleanup alerting api tests (#164438)
  Upgrade EUI to 87.2.0 (#164385)
  [ML] Fix query bar autocompletion for ML and AIOps embeddables (#164485)
  [Fleet] Fix flaky unit test for the details page (#164641)
  [Security Solution] update codeowner for serverless security subdir (#164640)
  [Security Solution] Fixes Assistant Connector and Actions RBAC Flow (#164382)
  [Discover] Removing large string truncation from doc viewer (#164236)
  ...
@maximpn
Copy link
Copy Markdown
Contributor

maximpn commented Aug 24, 2023

@banderror thank you for taking care of backports 👍

banderror added a commit that referenced this pull request Aug 24, 2023
@banderror @gitstart
[8.9] [Security Solution] Modal says "duplicating 0 rules" when you d…
128fde2 
…uplicate an individual rule (#163908) (#164687)

# Backport

This will backport the following commits from `main` to `8.9`:
- [[Security Solution] Modal says "duplicating 0 rules" when you
duplicate an individual rule
(#163908)](#163908)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"GitStart","email":"1501599+gitstart@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T07:13:17Z","message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","💝community","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.9.2"],"number":163908,"url":"https://github.com/elastic/kibana/pull/163908","mergeCommit":{"message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com>
banderror added a commit that referenced this pull request Aug 24, 2023
@banderror @gitstart
[8.10] [Security Solution] Modal says "duplicating 0 rules" when you …
93d4f66 
…duplicate an individual rule (#163908) (#164686)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Security Solution] Modal says "duplicating 0 rules" when you
duplicate an individual rule
(#163908)](#163908)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"GitStart","email":"1501599+gitstart@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-24T07:13:17Z","message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","💝community","Team:Detections
and Resp","Team: SecuritySolution","Feature:Rule
Management","Team:Detection Rule
Management","v8.10.0","v8.9.2"],"number":163908,"url":"https://github.com/elastic/kibana/pull/163908","mergeCommit":{"message":"[Security
Solution] Modal says \"duplicating 0 rules\" when you duplicate an
individual rule (#163908)\n\n ## What does this PR do?\r\n * It fixes
the count on the duplicate modal when duplicating an individual
rule.\r\n \r\n ## Issue References\r\nFixes #162035\r\n \r\n ##
Video/Screenshot Demo\r\n ##### Steps to reproduce &
Fix:\r\nhttps://www.loom.com/share/931e42c1490d4483958b8f98dc0ba534?sid=07c67df5-b380-41a5-90f1-f64f326a12d9\r\n\r\n___\r\n
\r\n This code was written and reviewed by GitStart Community. Growing
future engineers, one PR at a
time.","sha":"59f20582605d5dcb489b6534b027ec19475e7136"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: GitStart <1501599+gitstart@users.noreply.github.com>
This was referenced Oct 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience 💝community Feature:Rule Management Security Solution Detection Rule Management area release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.2 v8.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Security Solution] Modal says "duplicating 0 rules" when you duplicate an individual rule

6 participants

@gitstart @kibanamachine @elasticmachine @maximpn @banderror @kibana-ci