Skip to content

Update static lambdas from master#45093

Merged
RikkiGibson merged 8549 commits intodotnet:features/static-lambdasfrom
RikkiGibson:update-static-lambdas
Jun 16, 2020
Merged

Update static lambdas from master#45093
RikkiGibson merged 8549 commits intodotnet:features/static-lambdasfrom
RikkiGibson:update-static-lambdas

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Jun 11, 2020

This refreshes the static-lambdas feature branch. I didn't create this as a regular codeflow PR as there was a bit more manual fixup required than usual.

Commit a18548d requires manual review. Note that I dealt with PublicAPI conflicts by simply taking the master version of PublicAPI and then running the fixer in the manually reviewed commit. Thus the diff will just show where the feature branch added new APIs.

Please take a look @CyrusNajmabadi @jcouv

agocke and others added 30 commits June 4, 2020 11:53
…fig-engine-switching

Tweak .editorconfig legacy engine controls
…rTests.cs

Co-authored-by: Jason Malinowski <jason@jason-m.com>
…ory-watching

Watch directories for source files and some metadata references
We had enabled this rule as a build time enforcement for IDE projects, but it has caused bunch of build breaks and it turning out to be too onerous to enforce. It was decided that this would be better implemented as a post-build code cleanup bot.
Remove build enforcement of unused usings in IDE layers
Fixes dotnet#43788
TodoCommentOptions and TodoCommentOptionsProvider were defined in EditorFeatures layer and we only serialize the options defined in Workspaces and Features layer to the OOP side: https://github.com/dotnet/roslyn/blob/287a25a51324f252e61b6f2186e7df60c8a6161b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs#L79-L85

In future, we either need to add support to serialize all changed options to OOP (could be expensive) or somehow enforce that all the OOP related options are defined in Workspaces and Features layer.
Ensure that TodoCommentOptions are serialized to OOP
Potentially fixed a bug regarding static items not bolding
…ading

Fix fading locations for unnecessary code.
…rpRemoveUnnecessarySuppressionCodeFixProvider.cs

Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Embed generated source texts in the portable PDB:
- Allows stepping in etc. in the IDE as well as a dump debugging after compilation
- Consistent ordering of generated syntax trees.
- Unique hint names
- Restrict hint names to file path legal characters
- Add tests
@CyrusNajmabadi
Copy link
Contributor

Commit a18548d requires manual review.

I dont' see anything in there of concern. but i'm not a compiler dev :)

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks. Only reviewed the one commit resolving conflicts.

@jcouv jcouv self-assigned this Jun 12, 2020
@RikkiGibson
Copy link
Member Author

DeeplyNestedGeneric baseline probably needs to be adjusted again.

@RikkiGibson
Copy link
Member Author

@dotnet/roslyn-compiler Could I please get a second review on commit a18548d

@RikkiGibson RikkiGibson force-pushed the update-static-lambdas branch from 18f001a to 4fa72a0 Compare June 12, 2020 23:51
@RikkiGibson RikkiGibson requested a review from a team June 13, 2020 02:19
@RikkiGibson
Copy link
Member Author

Ping @dotnet/roslyn-compiler

@RikkiGibson
Copy link
Member Author

It sounds like this is acceptable to merge with a single sign-off.

@RikkiGibson RikkiGibson merged commit d9f418a into dotnet:features/static-lambdas Jun 16, 2020
@RikkiGibson RikkiGibson deleted the update-static-lambdas branch June 16, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.