Update static lambdas from master#45093
Merged
RikkiGibson merged 8549 commits intodotnet:features/static-lambdasfrom Jun 16, 2020
Merged
Update static lambdas from master#45093RikkiGibson merged 8549 commits intodotnet:features/static-lambdasfrom
RikkiGibson merged 8549 commits intodotnet:features/static-lambdasfrom
Conversation
…fig-engine-switching Tweak .editorconfig legacy engine controls
…rTests.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
…ory-watching Watch directories for source files and some metadata references
We had enabled this rule as a build time enforcement for IDE projects, but it has caused bunch of build breaks and it turning out to be too onerous to enforce. It was decided that this would be better implemented as a post-build code cleanup bot.
…hen offering suggestions
Remove redundant helper.
Change "data" to "record"
Remove build enforcement of unused usings in IDE layers
Fixes dotnet#43788 TodoCommentOptions and TodoCommentOptionsProvider were defined in EditorFeatures layer and we only serialize the options defined in Workspaces and Features layer to the OOP side: https://github.com/dotnet/roslyn/blob/287a25a51324f252e61b6f2186e7df60c8a6161b/src/Workspaces/Core/Portable/Options/GlobalOptionService.cs#L79-L85 In future, we either need to add support to serialize all changed options to OOP (could be expensive) or somehow enforce that all the OOP related options are defined in Workspaces and Features layer.
Ensure that TodoCommentOptions are serialized to OOP
Potentially fixed a bug regarding static items not bolding
…ading Fix fading locations for unnecessary code.
…rpRemoveUnnecessarySuppressionCodeFixProvider.cs Co-authored-by: Manish Vasani <mavasani@microsoft.com>
Embed generated source texts in the portable PDB: - Allows stepping in etc. in the IDE as well as a dump debugging after compilation - Consistent ordering of generated syntax trees. - Unique hint names - Restrict hint names to file path legal characters - Add tests
Contributor
I dont' see anything in there of concern. but i'm not a compiler dev :) |
jcouv
approved these changes
Jun 12, 2020
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks. Only reviewed the one commit resolving conflicts.
Change RichNav to run daily
Member
Author
|
DeeplyNestedGeneric baseline probably needs to be adjusted again. |
Target Remote.Workspaces to .NET Core 3.1
Support pattern variables declared under "is not" (dotnet#44513)
…espace_move Add history to move to namespace
Exclude entry points from unused members analysis
Use IActiveStatementSpanTrackerFactory through MEF
… merges/release/dev16.7-preview3-to-master
Significantly improve performance of dependent-project-finding
Always construct mocks as strict
Member
Author
|
@dotnet/roslyn-compiler Could I please get a second review on commit a18548d |
…eview3-to-master Merge release/dev16.7-preview3 to master
18f001a to
4fa72a0
Compare
Member
Author
|
Ping @dotnet/roslyn-compiler |
Member
Author
|
It sounds like this is acceptable to merge with a single sign-off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refreshes the static-lambdas feature branch. I didn't create this as a regular codeflow PR as there was a bit more manual fixup required than usual.
Commit a18548d requires manual review. Note that I dealt with PublicAPI conflicts by simply taking the master version of PublicAPI and then running the fixer in the manually reviewed commit. Thus the diff will just show where the feature branch added new APIs.
Please take a look @CyrusNajmabadi @jcouv