Use IActiveStatementSpanTrackerFactory through MEF#45004
Merged
sharwell merged 2 commits intodotnet:masterfrom Jun 12, 2020
Merged
Use IActiveStatementSpanTrackerFactory through MEF#45004sharwell merged 2 commits intodotnet:masterfrom
sharwell merged 2 commits intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Jun 9, 2020
tmat
reviewed
Jun 9, 2020
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
requested changes
Jun 9, 2020
Member
tmat
left a comment
There was a problem hiding this comment.
The EnC service should not fetch services from workspace. It's explicitly designed to accept all of its dependencies in the constructor and not use Workspace.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.