Fix fading locations for unnecessary code.#44817
Merged
4 commits merged intodotnet:masterfrom Jun 5, 2020
Merged
Conversation
Contributor
Author
|
Looking for a good place to add a test for this so we don't regress this. |
8d66aff to
8f4ca69
Compare
sharwell
suggested changes
Jun 3, 2020
src/EditorFeatures/Core/Implementation/Diagnostics/DiagnosticsClassificationTaggerProvider.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Jun 3, 2020
Member
dibarbet
left a comment
There was a problem hiding this comment.
Looks fine to me, pending Sam's changes
dibarbet
approved these changes
Jun 3, 2020
sharwell
approved these changes
Jun 3, 2020
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44816