Target Remote.Workspaces to .NET Core 3.1#45091
Merged
genlu merged 2 commits intodotnet:masterfrom Jun 12, 2020
Merged
Conversation
Member
|
I wonder if there is much benefit right now to target |
Member
Author
|
Not sure. I'm trying to be consistent with what @sharwell is doing. |
Contributor
|
@tmat netstandard2.0 is not a supported scenario for C# 8 or nullable reference types |
Member
|
OK, as long as we know what the reasons are. Just keep in mind that there might be a trade-off: if we make all projects multi-targeted we make Roslyn.sln much slower to work in. |
tmat
approved these changes
Jun 12, 2020
sharwell
reviewed
Jun 12, 2020
| <OutputType>Library</OutputType> | ||
| <RootNamespace>Microsoft.CodeAnalysis.Remote</RootNamespace> | ||
| <TargetFramework>net472</TargetFramework> | ||
| <TargetFrameworks>net472;netcoreapp3.1</TargetFrameworks> |
Contributor
There was a problem hiding this comment.
📝 netcoreapp3.1 should appear first in the list for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tmat @sharwell