Adapt IDE to new record syntax#44880
Conversation
| namespace Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.Recommendations | ||
| { | ||
| public class DataKeywordRecommenderTests : KeywordRecommenderTests | ||
| public class RecordKeywordRecommenderTests : KeywordRecommenderTests |
There was a problem hiding this comment.
RecordKeywordRecommenderTests [](start = 17, length = 29)
📝 this file is a duplicate of ClassKeywordRecommenderTests with one or two tests added, such as typing in position nested in record.
|
Pulled in @mavasani to help out with review since we're trying to merge this today. Thanks! |
mavasani
left a comment
There was a problem hiding this comment.
LGTM. All the changes look reasonable, though I don't have enough context to know if some places were missed out from being updated. If it turns out so, I don't see a problem in updating them later on.
|
@dotnet/roslyn-ide Can someone else also do a quick review as an additional sanity? |
|
@dotnet/roslyn-ide If anyone wants to take a look, please do it quick. We're aiming to get all records PRs merged by tonight. |
In particular, this removes completion for
dataand adds completion forrecords. This also fixes some other recommenders and fixers that didn't trigger on the new type syntax.Relates to #40726 (test plan)