Skip to content

Tweak .editorconfig legacy engine controls#44847

Merged
jasonmalinowski merged 2 commits intodotnet:masterfrom
jasonmalinowski:update-editorconfig-engine-switching
Jun 4, 2020
Merged

Tweak .editorconfig legacy engine controls#44847
jasonmalinowski merged 2 commits intodotnet:masterfrom
jasonmalinowski:update-editorconfig-engine-switching

Conversation

@jasonmalinowski
Copy link
Member

Two small changes:

  1. Remove some unused bits for the experiment that is no longer active.
  2. Change the storage location for the option to use legacy .editorconfig.

To explain the second bit:

We originally offered this checkbox as a way for users who were broken by our .editorconfig support to have an opt-out while we diagnosed what issues they were running into. At this point we aren't tracking any bugs, so we want anybody who had checked this checkbox to get the new experience again in hopes that their problems are now addressed. If we don't hear any additional feedback, we'll remove the legacy engine entirely in 16.8.

This constant was no longer used.
We originally offered this checkbox as a way for users who were broken
by our .editorconfig support to have an opt-out while we diagnosed what
issues they were running into. At this point we aren't tracking any
bugs, so we want anybody who had checked this checkbox to get the new
experience again in hopes that their problems are now addressed. If we
don't hear any additional feedback, we'll remove the legacy engine
entirely in 16.8.
@jasonmalinowski jasonmalinowski requested a review from a team as a code owner June 4, 2020 01:37
@jasonmalinowski jasonmalinowski self-assigned this Jun 4, 2020
@jasonmalinowski jasonmalinowski merged commit 51b329c into dotnet:master Jun 4, 2020
@ghost ghost added this to the Next milestone Jun 4, 2020
@jasonmalinowski jasonmalinowski deleted the update-editorconfig-engine-switching branch June 4, 2020 18:54
@RikkiGibson RikkiGibson modified the milestones: Next, 16.7.P3 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants